Taking this review.

> %define __cmake_in_source_build 1

I think you can drop this and simplify this spec since we do out-of-source builds properly and automatically now.

> # No binary at all, so disable debuginfo package
> %global debug_package %{nil}

This can be dropped since you have "BuildArch: noarch" already.

> mkdir build
> cd build
> %cmake3 -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO ..

This should be replaced with "%cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO".

> cd build
> make install/fast DESTDIR=%{buildroot}

This should be replaced with "%cmake_install"

Thanks for the review.
SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-x86_64/06815764-lxqt-menu-data/lxqt-menu-data.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-x86_64/06815764-lxqt-menu-data/lxqt-menu-data-1.4.1-1.fc40.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6815985
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255886-lxqt-menu-data/fedora-rawhide-x86_64/06815985-lxqt-menu-data/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Created attachment 2005968 [details]
The .spec file difference from Copr build 6815985 to 6815986

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6815986
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255886-lxqt-menu-data/fedora-rawhide-x86_64/06815986-lxqt-menu-data/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> %build
> mkdir build
> cd build
> %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO ..
> %cmake_build
> 
> %install
> cd build
> %cmake_install

This should be simplified to:

> %build
> %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO
> %cmake_build
> 
> %install
> %cmake_install

If you need it to do out of source builds in RHEL < 9, then add the following to the top of your spec file:

%undefine __cmake_in_source_build

(In reply to Neal Gompa from comment #7)
> This should be simplified to:
> 
> > %build
> > %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO
> > %cmake_build
> > 
> > %install
> > %cmake_install
> 

Thanks. Historically some of the LXQt packages cannot be built in source root. But looks like this one works just fine.

> If you need it to do out of source builds in RHEL < 9, then add the
> following to the top of your spec file:
> 
> %undefine __cmake_in_source_build

I'll do it only when I plan to update in EPEL.

SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-x86_64/06820855-lxqt-menu-data/lxqt-menu-data.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/lxqt/fedora-rawhide-x86_64/06820855-lxqt-menu-data/lxqt-menu-data-1.4.1-1.fc40.src.rpm

(In reply to Zamir SUN from comment #8)
> (In reply to Neal Gompa from comment #7)
> > This should be simplified to:
> > 
> > > %build
> > > %cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO
> > > %cmake_build
> > > 
> > > %install
> > > %cmake_install
> > 
> 
> Thanks. Historically some of the LXQt packages cannot be built in source
> root. But looks like this one works just fine.
> 

Right, KDE is the same way. We have a derivative %cmake macro (called %cmake_kf5 or now %cmake_kf6) that enforces this. If you have a similar %cmake_lxqt macro, you can enforce it there. But it's also not needed if you do not care about anything older than RHEL 9, since the regular %cmake macro sets up out of source builds by default since Fedora 33 / RHEL 9.

Cf. https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/lxqt-menu-data