Bug 2255997 - Review Request: golang-github-erkexzcx-valetudopng - Valetudo map renderer for Home Assistant
Summary: Review Request: golang-github-erkexzcx-valetudopng - Valetudo map renderer fo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-27 17:13 UTC by Davide Cavalca
Modified: 2024-01-14 00:59 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-05 02:57:21 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-12-27 17:13:08 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-erkexzcx-valetudopng/golang-github-erkexzcx-valetudopng.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-erkexzcx-valetudopng/golang-github-erkexzcx-valetudopng-1.0.15-1.fc40.src.rpm

Description:
A Valetudo map renderer (ex Hypfer/ICantBelieveItsNotValetudo) for Home
Assistant.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-12-27 17:13:11 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110921398

Comment 2 Fedora Review Service 2023-12-28 10:04:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6823504
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255997-golang-github-erkexzcx-valetudopng/fedora-rawhide-x86_64/06823504-golang-github-erkexzcx-valetudopng/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-01-05 02:46:19 UTC
Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Golang Packaging Guidelines

Package APPROVED.

===

Recommended post-import go-sig tasks (use `fedora-sig-onboard onboard $goname`:

- add @go-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @go-sig (optional)

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-05 02:48:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-erkexzcx-valetudopng

Comment 5 Fedora Update System 2024-01-05 02:55:29 UTC
FEDORA-2024-510c248ba5 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-510c248ba5

Comment 6 Fedora Update System 2024-01-05 02:57:21 UTC
FEDORA-2024-510c248ba5 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-01-05 03:11:19 UTC
FEDORA-2024-af0229b355 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-af0229b355

Comment 8 Fedora Update System 2024-01-05 03:51:49 UTC
FEDORA-2024-f0c51b5131 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f0c51b5131

Comment 9 Fedora Update System 2024-01-06 01:13:47 UTC
FEDORA-2024-af0229b355 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-af0229b355 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-af0229b355

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-01-06 01:34:21 UTC
FEDORA-2024-f0c51b5131 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f0c51b5131 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f0c51b5131

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-14 00:46:53 UTC
FEDORA-2024-f0c51b5131 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-01-14 00:59:25 UTC
FEDORA-2024-af0229b355 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.