Fedora Merge Review: beagle http://cvs.fedora.redhat.com/viewcvs/devel/beagle/ Initial Owner: alexl
Okay, here comes rpmlint on the latest in rawhide: beagle.src: W: strange-permission beagle-thunderbird-update.sh 0775 Probably safe to ignore. beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-windows beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/BeagleSearch.xml beagle.x86_64: W: non-conffile-in-etc /etc/beagle/query-mapping.xml beagle.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/beagled-autostart.desktop beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-applications beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Networking.xml beagle.x86_64: W: non-conffile-in-etc /etc/beagle/blocate.conf beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-monodoc beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Daemon.xml beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-documentation beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-executables beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/FilesQueryable.xml beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-manpages Please mark all of these as %config(noreplace). beagle.x86_64: E: non-executable-script /usr/lib64/beagle/keygrabber.py 0644 Please fix permissions on that script. beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx Safe to ignore. beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config beagle.x86_64: W: devel-file-in-non-devel-package /usr/lib64/beagle/libbeagleglue.so beagle.x86_64: E: explicit-lib-dependency libbeagle Safe to ignore. Odd that it doesn't end up building against libbeagle though. beagle.x86_64: W: dangerous-command-in-%post rm beagle.x86_64: W: dangerous-command-in-%preun rm Safe to ignore. beagle-devel.x86_64: W: no-documentation Please mark /usr/lib64/monodoc/sources/beagle-docs.* as %doc. beagle-devel.x86_64: E: only-non-binary-in-usr-lib Safe to ignore. beagle-epiphany.x86_64: W: no-documentation beagle-epiphany.x86_64: E: only-non-binary-in-usr-lib Safe to ignore. beagle-epiphany.x86_64: E: non-executable-script /usr/lib64/epiphany/2.24/extensions/beagle.py 0644 Please fix permissions on that script. beagle-evolution.x86_64: W: no-documentation beagle-evolution.x86_64: E: only-non-binary-in-usr-lib beagle-firefox.x86_64: W: no-documentation Safe to ignore. beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.xul beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/indexLink.xul beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/utils.js beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/beagle.dtd beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.js Are these really executable scripts? Do they need to be chmod +x? beagle-firefox.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf Please fix the end of line encoding here. sed -i 's/\r//' foo beagle-firefox.x86_64: E: only-non-binary-in-usr-lib beagle-gnome.x86_64: W: no-documentation Safe to ignore. beagle-gnome.x86_64: W: devel-file-in-non-devel-package /usr/lib64/beagle/libbeagleuiglue.so You should have a beagle-gnome-devel package for this one. beagle-thunderbird.x86_64: W: no-documentation beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib Safe to ignore. ***** Please make the changes that I illustrated from rpmlint, and I'll finish the review.
Thanks for the initial review, I have missed them because I was not CCed on this bug. I will address the issues noted next week.
(In reply to comment #1) > Okay, here comes rpmlint on the latest in rawhide: > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-windows > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/BeagleSearch.xml > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/query-mapping.xml OK, done. > beagle.x86_64: W: non-conffile-in-etc > /etc/xdg/autostart/beagled-autostart.desktop Not sure if this should be threated like a config file... > beagle.x86_64: W: non-conffile-in-etc > /etc/beagle/crawl-rules/crawl-applications > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Networking.xml > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/blocate.conf > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-monodoc > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Daemon.xml > beagle.x86_64: W: non-conffile-in-etc > /etc/beagle/crawl-rules/crawl-documentation > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-executables > beagle.x86_64: W: non-conffile-in-etc > /etc/beagle/config-files/FilesQueryable.xml > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-manpages > > Please mark all of these as %config(noreplace). OK, done. > beagle.x86_64: E: non-executable-script /usr/lib64/beagle/keygrabber.py 0644 > > Please fix permissions on that script. OK, done > beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx > beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx > beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx > beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx > > Safe to ignore. > > beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config > beagle.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/beagle/libbeagleglue.so > > beagle.x86_64: E: explicit-lib-dependency libbeagle > > Safe to ignore. Odd that it doesn't end up building against libbeagle though. Is linked at runtime (dlopen) > beagle-epiphany.x86_64: E: non-executable-script > /usr/lib64/epiphany/2.24/extensions/beagle.py 0644 > > Please fix permissions on that script. Fixed. > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.xul > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/indexLink.xul > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/utils.js > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/beagle.dtd > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.js > > Are these really executable scripts? Do they need to be chmod +x? No, fixed. > beagle-firefox.x86_64: E: wrong-script-end-of-line-encoding > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf > > Please fix the end of line encoding here. sed -i 's/\r//' foo > > beagle-firefox.x86_64: E: only-non-binary-in-usr-lib > beagle-gnome.x86_64: W: no-documentation > > Safe to ignore. > > beagle-gnome.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/beagle/libbeagleuiglue.so > > You should have a beagle-gnome-devel package for this one. No this file gets dlopened its not something that is linked against at build time. > beagle-thunderbird.x86_64: W: no-documentation > beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib > > Safe to ignore. > > ***** > > Please make the changes that I illustrated from rpmlint, and I'll finish the > review. Thanks, fixed in 0.3.9-4
Looks like rpmlint caught one missing -x case, you should add: find $RPM_BUILD_ROOT -name '*.css' -exec chmod a-x {} ';' Two more things I noticed: * the -devel package probably needs to have a Requires: %{name} = %{version}-%{release} * You should get rid of the userdel/groupdel commands in %post. Removing users is dangerous enough (what if a user chooses "beagleindex" for their username?), and this particular username hasn't been used in a beagle package since before Fedora 7. == Review == - rpmlint checks return: beagle.src: W: strange-permission beagle-thunderbird-update.sh 0775 beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx beagle.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/beagled-autostart.desktop beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config beagle.x86_64: W: devel-file-in-non-devel-package /usr/lib64/beagle/libbeagleglue.so beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx beagle.x86_64: E: explicit-lib-dependency libbeagle beagle.x86_64: W: dangerous-command-in-%post rm beagle.x86_64: W: dangerous-command-in-%preun rm beagle-gnome.x86_64: W: no-documentation beagle-gnome.x86_64: W: devel-file-in-non-devel-package /usr/lib64/beagle/libbeagleuiglue.so beagle-evolution.x86_64: W: no-documentation beagle-evolution.x86_64: E: only-non-binary-in-usr-lib beagle-thunderbird.x86_64: W: no-documentation beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib beagle-firefox.x86_64: W: no-documentation beagle-firefox.x86_64: E: script-without-shebang /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css beagle-firefox.x86_64: E: only-non-binary-in-usr-lib beagle-epiphany.x86_64: W: no-documentation beagle-epiphany.x86_64: E: only-non-binary-in-usr-lib beagle-devel.x86_64: E: only-non-binary-in-usr-lib All safe to ignore, except the executable .css. - package meets naming guidelines - package meets packaging guidelines - license (ASL 2.0 and MIT and BSD and CC-BY and LGPLv2+ and (AFL or LGPLv2+)) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok (except for one .css file) - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop files okay - devel package ok (except for missing requires) - no .la files - post/postun ldconfig not needed for mono == With those three items above resolved, I will approve this review. Thanks in advance.
(In reply to comment #4) > Looks like rpmlint caught one missing -x case, you should add: > > find $RPM_BUILD_ROOT -name '*.css' -exec chmod a-x {} ';' Missed this one, fixed. > Two more things I noticed: > > * the -devel package probably needs to have a Requires: %{name} = > %{version}-%{release} Adeed. > * You should get rid of the userdel/groupdel commands in %post. Removing users > is dangerous enough (what if a user chooses "beagleindex" for their username?), > and this particular username hasn't been used in a beagle package since before > Fedora 7. Agreed, fixed. > == Review == > - rpmlint checks return: > beagle.src: W: strange-permission beagle-thunderbird-update.sh 0775 > beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx > beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx > beagle.x86_64: W: non-conffile-in-etc > /etc/xdg/autostart/beagled-autostart.desktop > beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config > beagle.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/beagle/libbeagleglue.so > beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample > beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx > beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx > beagle.x86_64: E: explicit-lib-dependency libbeagle > beagle.x86_64: W: dangerous-command-in-%post rm > beagle.x86_64: W: dangerous-command-in-%preun rm > beagle-gnome.x86_64: W: no-documentation > beagle-gnome.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/beagle/libbeagleuiglue.so > beagle-evolution.x86_64: W: no-documentation > beagle-evolution.x86_64: E: only-non-binary-in-usr-lib > beagle-thunderbird.x86_64: W: no-documentation > beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib > beagle-firefox.x86_64: W: no-documentation > beagle-firefox.x86_64: E: script-without-shebang > /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css > beagle-firefox.x86_64: E: only-non-binary-in-usr-lib > beagle-epiphany.x86_64: W: no-documentation > beagle-epiphany.x86_64: E: only-non-binary-in-usr-lib > beagle-devel.x86_64: E: only-non-binary-in-usr-lib > > All safe to ignore, except the executable .css. > > - package meets naming guidelines > - package meets packaging guidelines > - license (ASL 2.0 and MIT and BSD and CC-BY and LGPLv2+ and (AFL or LGPLv2+)) > OK, text in %doc, matches source > - spec file legible, in am. english > - source matches upstream > - package compiles on devel (x86_64) > - no missing BR > - no unnecessary BR > - no locales > - not relocatable > - owns all directories that it creates > - no duplicate files > - permissions ok (except for one .css file) > - %clean ok > - macro use consistent > - code, not content > - no need for -docs > - nothing in %doc affects runtime > - .desktop files okay > - devel package ok (except for missing requires) > - no .la files > - post/postun ldconfig not needed for mono > > == > With those three items above resolved, I will approve this review. > > Thanks in advance. Fixed in 0.3.9-5, thanks for the review.
Looks good. APPROVED and closing out.