Spec URL: https://thunderbirdtr.fedorapeople.org/raylib/raylib.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/raylib/raylib-5.0-1.fc40.src.rpm Description: simple and easy-to-use library to enjoy videogames programming. Fedora Account System Username: thunderbirdtr
Taking this review.
Initial spec review: > License: zlib License This should use SPDX license tags, so it should be "Zlib". > #BuildRequires: libglfw-devel >= 3.4 This should be "glfw-devel >= 3.4" > %post > %?ldconfig > > %postun > %?ldconfig These are not needed unless you're supporting RHEL 7, and even then you should use "%ldconfig_scriptlets" instead. > %{_libdir}/cmake/raylib/%{name}-config-version.cmake > %{_libdir}/cmake/raylib/%{name}-config.cmake You need to either change to "%{_libdir}/cmake/raylib/" or add a "%dir %{_libdir}/cmake/raylib" stanza.
All done. Please re-check
> %autosetup -n %{name}-%{version} -p1 This can just be "%autosetup -p1" since the "-n %{name}-%{version}" is redundant.
Done as well.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "zlib License", "BSD 3-Clause License", "*No copyright* MIT License", "Kevlin Henney License", "MIT No Attribution and/or The Unlicense", "*No copyright* Do What The Fuck You Want To Public License, Version 2", "MIT License", "MIT License and/or The Unlicense", "*No copyright* SIL Open Font License 1.1", "SIL Open Font License 1.1", "*No copyright* zlib License", "Simple Public License and/or zlib License", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Public domain", "GNU Lesser General Public License v2.1 or later". 816 files have unknown license. Detailed output of licensecheck in /home/ngompa/2256153-raylib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 253747 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: raylib-5.0-1.fc40.x86_64.rpm raylib-devel-5.0-1.fc40.x86_64.rpm raylib-debuginfo-5.0-1.fc40.x86_64.rpm raylib-debugsource-5.0-1.fc40.x86_64.rpm raylib-5.0-1.fc40.src.rpm ========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp45dpw0mb')] checks: 31, packages: 5 raylib.src: W: no-version-in-last-changelog raylib.x86_64: W: no-version-in-last-changelog raylib-debuginfo.x86_64: W: no-version-in-last-changelog raylib-debugsource.x86_64: W: no-version-in-last-changelog raylib-devel.x86_64: W: no-version-in-last-changelog =========================================================== 5 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 1.2 s =========================================================== Rpmlint (debuginfo) ------------------- Checking: raylib-debuginfo-5.0-1.fc40.x86_64.rpm ========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcmvuc2_d')] checks: 31, packages: 1 raylib-debuginfo.x86_64: W: no-version-in-last-changelog =========================================================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s =========================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 raylib.x86_64: E: spelling-error ('videogames', 'Summary(en_US) videogames -> video games, video-games, videotapes') raylib.x86_64: E: spelling-error ('videogames', '%description -l en_US videogames -> video games, video-games, videotapes') raylib-debugsource.x86_64: W: no-version-in-last-changelog raylib.x86_64: W: no-version-in-last-changelog raylib-debuginfo.x86_64: W: no-version-in-last-changelog raylib-devel.x86_64: W: no-version-in-last-changelog 4 packages and 0 specfiles checked; 2 errors, 4 warnings, 29 filtered, 2 badness; has taken 0.7 s Source checksums ---------------- https://github.com/raysan5/raylib/archive/5.0/raylib-5.0.tar.gz : CHECKSUM(SHA256) this package : 98f049b9ea2a9c40a14e4e543eeea1a7ec3090ebdcd329c4ca2cf98bc9793482 CHECKSUM(SHA256) upstream package : 98f049b9ea2a9c40a14e4e543eeea1a7ec3090ebdcd329c4ca2cf98bc9793482 Requires -------- raylib (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) raylib-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libXcursor-devel libXi-devel libXinerama-devel libXrandr-devel libraylib.so.450()(64bit) libxkbcommon-devel mesa-libGL-devel raylib(x86-64) wayland-devel wayland-protocols-devel raylib-debuginfo (rpmlib, GLIBC filtered): raylib-debugsource (rpmlib, GLIBC filtered): Provides -------- raylib: libraylib.so.450()(64bit) raylib raylib(x86-64) raylib-devel: cmake(raylib) pkgconfig(raylib) raylib-devel raylib-devel(x86-64) raylib-debuginfo: debuginfo(build-id) libraylib.so.4.5.0-5.0-1.fc40.x86_64.debug()(64bit) raylib-debuginfo raylib-debuginfo(x86-64) raylib-debugsource: raylib-debugsource raylib-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/ngompa/2256153-raylib/srpm/raylib.spec 2023-12-28 20:26:05.275848648 -0500 +++ /home/ngompa/2256153-raylib/srpm-unpacked/raylib.spec 2023-12-28 19:00:00.000000000 -0500 @@ -60,5 +60,5 @@ %prep -%autosetup -p1 +%autosetup -n %{name}-%{version} -p1 %build @@ -98,4 +98,4 @@ %changelog -* Fri Dec 29 2023 Onuralp Sezer <thunderbirdtr> - 5.0-1 +* Fri Dec 29 2023 Onuralp Sezer <thunderbirdtr> - initial package \ No newline at end of file Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2256153 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Haskell, PHP, Python, fonts, Java, SugarActivity, Ocaml, R, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Created attachment 2006426 [details] licensecheck.txt (In reply to Neal Gompa from comment #6) > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "zlib License", "BSD 3-Clause License", > "*No copyright* MIT License", "Kevlin Henney License", "MIT No > Attribution and/or The Unlicense", "*No copyright* Do What The Fuck > You Want To Public License, Version 2", "MIT License", "MIT License > and/or The Unlicense", "*No copyright* SIL Open Font License 1.1", > "SIL Open Font License 1.1", "*No copyright* zlib License", "Simple > Public License and/or zlib License", "*No copyright* Creative Commons > CC0 1.0", "*No copyright* Public domain", "GNU Lesser General Public > License v2.1 or later". 816 files have unknown license. Detailed > output of licensecheck in /home/ngompa/2256153-raylib/licensecheck.txt I've attached the licensecheck.txt file for review so you can fix this.
I added license tag "MIT" and rest of them already covered and projects and other certain don't come with package it is all good as well.
Looks good to me now, so... PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/raylib
Please close your review bugs once they've been imported.