Bug 225623 - Merge Review: bootparamd
Merge Review: bootparamd
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 12:46 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-23 14:34 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-23 14:34:30 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 12:46:39 EST
Fedora Merge Review: bootparamd

http://cvs.fedora.redhat.com/viewcvs/devel/bootparamd/
Initial Owner: stransky@redhat.com
Comment 1 Ruben Kerkhof 2007-03-18 08:30:39 EDT
Needs work:
* Package does not follow Fedora's package naming guildlines
  (wiki: PackageNamingGuidelines)
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Encoding should be UTF-8
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets)
* Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)

Rpmlint is not silent:

Source RPM:
W: bootparamd summary-ended-with-dot A server process which provides boot information to diskless 
clients.
E: bootparamd tag-not-utf8 %changelog
W: bootparamd no-url-tag
W: bootparamd strange-permission bootparamd.init 0775
E: bootparamd non-utf8-spec-file bootparamd.spec
W: bootparamd prereq-use /sbin/chkconfig /etc/init.d
E: bootparamd use-of-RPM_SOURCE_DIR
W: bootparamd mixed-use-of-spaces-and-tabs (spaces: line 49, tab: line 1)

rpmlint of bootparamd:
W: bootparamd summary-ended-with-dot A server process which provides boot information to diskless 
clients.
E: bootparamd tag-not-utf8 %changelog
W: bootparamd no-url-tag
W: bootparamd conffile-without-noreplace-flag /etc/rc.d/init.d/bootparamd
E: bootparamd executable-marked-as-config-file /etc/rc.d/init.d/bootparamd
Comment 2 Ruben Kerkhof 2007-06-17 02:35:09 EDT
Ping?
Comment 3 Martin Stransky 2007-09-10 06:16:37 EDT
That should be fixed with the current package maintainer who is Ondrej Dvoracek. 
Comment 4 Ondrej Dvoracek 2007-10-08 06:15:39 EDT
Hi,

> * Package does not follow Fedora's package naming guildlines
>   (wiki: PackageNamingGuidelines)
renamed source tarball so it matches upstream tarball and added correct upstream
source tarball url

> * BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>   (wiki: PackagingGuidelines#BuildRoot)
corrected the BuildRoot

> * Encoding should be UTF-8
removed invalid character from spec file

> * The package should contain the text of the license
>   (wiki: Packaging/ReviewGuidelines)
the upstream package does not contain the text of the license so I can't add the
license text to the tarball

> * Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets)
> * Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)
corrected scriptlets according to the ScriptletsSnippets

RPMLINT:

Source RPM:
> W: bootparamd summary-ended-with-dot A server process which provides boot
information to diskless clients.
removed dot

> E: bootparamd tag-not-utf8 %changelog
removed invalid character from changelog

> W: bootparamd no-url-tag
there is no bootparamd page

> W: bootparamd strange-permission bootparamd.init 0775
don't know what to do with that, many other services has the same problem

> E: bootparamd non-utf8-spec-file bootparamd.spec
removed invalid character from spec file

> W: bootparamd prereq-use /sbin/chkconfig /etc/init.d
removed prereq use and added correct requires according to the ScriptletsSnippets

> E: bootparamd use-of-RPM_SOURCE_DIR
removed usage of RPM_SOURCE_DIR

> W: bootparamd mixed-use-of-spaces-and-tabs (spaces: line 49, tab: line 1)
using spaces

rpmlint of bootparamd:
> W: bootparamd summary-ended-with-dot A server process which provides boot
information to diskless clients.
removed dot

> E: bootparamd tag-not-utf8 %changelog
removed invalid character from changelog

> W: bootparamd no-url-tag
there is no bootparamd page

> W: bootparamd conffile-without-noreplace-flag /etc/rc.d/init.d/bootparamd
> E: bootparamd executable-marked-as-config-file /etc/rc.d/init.d/bootparamd
/etc/rc.d/init.d/bootparamd is not a config file

Cheers Ondrej
Comment 5 Ruben Kerkhof 2007-11-26 10:53:38 EST
Hi Ondrej,

> W: bootparamd strange-permission bootparamd.init 0775
don't know what to do with that, many other services has the same problem

This is a warning because the file has 0775 permissions in CVS, chmodding 0664 will fix that.

>> W: bootparamd no-url-tag
> there is no bootparamd page

Agreed.

All the other issues are resolved.

Thanks,

Ruben
Comment 6 Ondrej Dvoracek 2007-11-26 11:15:23 EST
Hi,
I know where the problem is, but I can't change permissions in CVS. We've looked
at it with my colleague and it is common that permissions of init files are set
like these. So we've filed a bug on rpmlint upstream and you can see the result
on http://rpmlint.zarb.org/cgi-bin/trac.cgi/ticket/110. That is everything I can
do with that.
Cheers Ondrej
Comment 7 Ruben Kerkhof 2007-11-26 15:05:45 EST
Maybe you could do a CVS Admin Request 
(http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure) to have the permissions changed 
in the repository?
Comment 8 Ruben Kerkhof 2008-01-21 17:21:10 EST
Hi cvs admins,

Would it be possible to change the permissions on bootparamd.init to 0664 in the repo?
Comment 9 Kevin Fenzi 2008-01-22 18:46:24 EST
It might be possible, but I don't have permissions to do so. 
Will see if it can be done.
Comment 10 Jason Tibbitts 2008-01-22 19:00:45 EST
Well, there's /cvs/pkgs/rpms/bootparamd/devel on cvs-int, which does show
bootparamd.init,v as being mode 555.  I have no idea what would happen if that
were changed to 444.
Comment 11 Toshio Ernie Kuratomi 2008-01-23 14:17:55 EST
Okay.  /cvs/pkgs/rpms/bootparamd/devel has had its mode changed to 0444.  Let us
know if that causes any problems (it should do exactly what you want.)
Comment 12 Ruben Kerkhof 2008-01-23 14:34:30 EST
Thanks, it's fixed!

I don't see any further issues so this package is approved.

Note You need to log in before you can comment on or make changes to this bug.