Bug 2256306 - Review Request: golang-github-aphistic-sweet - Sweet is a pluggable test runner capable of hooking into standard Go tests
Summary: Review Request: golang-github-aphistic-sweet - Sweet is a pluggable test runn...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Arthur Bols
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2256304
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-31 01:33 UTC by W. Michael Petullo
Modified: 2024-02-01 21:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-01 19:15:48 UTC
Type: ---
Embargoed:
arthur: fedora-review-


Attachments (Terms of Use)

Description W. Michael Petullo 2023-12-31 01:33:01 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-aphistic-sweet.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-aphistic-sweet-0.3.0-1.fc39.src.rpm
Description: Sweet is a pluggable test runner capable of hooking into standard Go tests
Fedora Account System Username: mikep

This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.

Comment 2 Fedora Review Service 2023-12-31 19:22:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840055
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256306-golang-github-aphistic-sweet/fedora-rawhide-x86_64/06840055-golang-github-aphistic-sweet/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aphistic-sweet
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 W. Michael Petullo 2024-01-06 21:33:10 UTC
Unretire request: https://pagure.io/releng/issue/11879

Comment 4 Arthur Bols 2024-02-01 19:15:48 UTC
Sorry, but I can't approve this package.

This is a test runner that doesn't work with Go versions newer than 1.18. This package does not work and is probably never going to work (last commit was 5 years ago). 
Disabling all tests isn't a solution since all libraries that depend on sweet will also fail.

For golang-github-aphistic-golf, if the library still works on newer Go versions, you could disable the tests.

I'm closing this as WONTFIX.


Note You need to log in before you can comment on or make changes to this bug.