Bug 2256309 - Review Request: golang-github-bep-logg - A Fast and Structured logging package for Go
Summary: Review Request: golang-github-bep-logg - A Fast and Structured logging packag...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2209669
TreeView+ depends on / blocked
 
Reported: 2023-12-31 01:36 UTC by W. Michael Petullo
Modified: 2024-02-05 18:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-05 18:05:32 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-12-31 01:36:22 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-logg.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-logg-0.4.0-1.fc39.src.rpm
Description: A Fast and Structured logging package for Go
Fedora Account System Username: mikep

This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.

Comment 1 W. Michael Petullo 2023-12-31 18:44:25 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-logg.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-logg-0.4.0-1.fc39.src.rpm

Rebuild with go2rpm 1.10.0.

Comment 2 Fedora Review Service 2023-12-31 19:17:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840052
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256309-golang-github-bep-logg/fedora-rawhide-x86_64/06840052-golang-github-bep-logg/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-12-31 19:18:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840032
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256309-golang-github-bep-logg/fedora-rawhide-x86_64/06840032-golang-github-bep-logg/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Arthur Bols 2024-02-01 19:43:21 UTC
The dependency on golang-github-apex-log is only needed for the benchmarks. I believe those shouldn't be packaged anyway, so you can safely omit/rm those and remove the dependency.

Comment 5 W. Michael Petullo 2024-02-01 23:37:33 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-logg.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-logg-0.4.0-1.fc39.src.rpm

Remove benchmarks directory, and thus dependency on golang-github-apex-log. This was Arthur's suggestion; thank you!

Comment 6 Fedora Review Service 2024-02-01 23:41:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6980778
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256309-golang-github-bep-logg/fedora-rawhide-x86_64/06980778-golang-github-bep-logg/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Mikel Olasagasti Uranga 2024-02-05 17:41:49 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 8 Fedora Admin user for bugzilla script actions 2024-02-05 17:44:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-logg

Comment 9 Fedora Update System 2024-02-05 17:55:45 UTC
FEDORA-2024-3d71e5d967 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3d71e5d967

Comment 10 Fedora Update System 2024-02-05 18:05:32 UTC
FEDORA-2024-3d71e5d967 (golang-github-bep-logg-0.4.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.