Bug 2256312 - Review Request: golang-github-tj-assert - Testify/assert but as testify/require
Summary: Review Request: golang-github-tj-assert - Testify/assert but as testify/require
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2256304 2256313
TreeView+ depends on / blocked
 
Reported: 2023-12-31 01:39 UTC by W. Michael Petullo
Modified: 2024-01-13 00:18 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-13 00:18:17 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-12-31 01:39:21 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-tj-assert.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-tj-assert-0.0.3-1.fc39.src.rpm
Description: Testify/assert but as testify/require
Fedora Account System Username: mikep

This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.

Comment 1 W. Michael Petullo 2023-12-31 18:43:07 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-tj-assert.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-tj-assert-0.0.3-1.fc39.src.rpm

Rebuild with go2rpm 1.10.0.

Comment 2 Fedora Review Service 2023-12-31 19:20:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840035
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256312-golang-github-tj-assert/fedora-rawhide-x86_64/06840035-golang-github-tj-assert/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-tj-assert
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-12-31 19:20:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840049
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256312-golang-github-tj-assert/fedora-rawhide-x86_64/06840049-golang-github-tj-assert/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-tj-assert
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Mikel Olasagasti Uranga 2024-01-02 21:23:07 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 5 W. Michael Petullo 2024-01-05 01:49:54 UTC
https://pagure.io/releng/issue/11869


Note You need to log in before you can comment on or make changes to this bug.