Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://trix.fedorapeople.org/foxi.spec SPRM URL: https://trix.fedorapeople.org/foxi-1.4.1%5egit20210526.c278588-1.fc40.src.rpm This is needed to build caffe2, a part of PyTorch here https://src.fedoraproject.org/rpms/python-torch/blob/rawhide/f/python-torch.spec#_146 Reproducible: Always
I am not sure that protobuf-lite is the best config for onnx, it causes build problems in pytorch. Can it change ?
Copr build: https://copr.fedorainfracloud.org/coprs/build/6840042 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256338-foxi/fedora-rawhide-x86_64/06840042-foxi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> I am not sure that protobuf-lite is the best config for onnx, it causes build problems in pytorch. > Can it change? I did not know it could be problematic. I have pushed to rawhide a new build using protobuf-devel instead[1]. (Likewise for onnxruntime [2]) [1] https://bodhi.fedoraproject.org/updates/FEDORA-2024-977c90cf0f [2] https://bodhi.fedoraproject.org/updates/FEDORA-2024-8c7ecca949 Thanks for the heads up.
Spec URL: https://trix.fedorapeople.org/foxi.spec SRPM URL: https://trix.fedorapeople.org/foxi-1.4.1%5egit20210526.c278588-2.fc41.src.rpm This change switches to from lite to regular protobuf And will be used in the upcoming pytorch 2.3 Here is where it is used to enable building the caffe2 option. https://src.fedoraproject.org/rpms/python-torch/blob/rhel-test/f/python-torch.spec#_197
Created attachment 2018212 [details] The .spec file difference from Copr build 6840042 to 7050355
Copr build: https://copr.fedorainfracloud.org/coprs/build/7050355 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256338-foxi/fedora-rawhide-x86_64/07050355-foxi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm on F39 and building for rawhide in mock does not work well for me. I couldn't even use the fedora-review tool. $ rpmlint *.rpm rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 foxi.src: E: unknown-key 83f22833 foxi.x86_64: E: unknown-key 83f22833 foxi-debuginfo.x86_64: E: unknown-key 83f22833 foxi-debugsource.x86_64: E: unknown-key 83f22833 foxi-devel.x86_64: E: unknown-key 83f22833 foxi.x86_64: W: no-documentation foxi-devel.x86_64: W: no-documentation foxi.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/5c/167b005732030d0d8456ae8c645f17ed60ae92 ../../../../usr/lib64/libfoxi.so ====== 5 packages and 0 specfiles checked; 5 errors, 3 warnings, 30 filtered, 5 badness; has taken 0.5 s the only relevant issue is the last warning about the dangling symlink; I can see you %exclude libfoxi it in the %files section: %exclude %{_libdir}/libfoxi.so should the symlink be removed as well? I went through all the MUST and SHOULD items manually since fedora-review doesn't work for me and all passed. The issue with the symlink doesn't seem blocking to me. Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/foxi