* RPM name is OK
* Source cpio-2.6.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* BuildRequires: gettext is missing (required to build the translations)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Please preserve timestamps when installing files

rpmlint is not silent:

[ruben@odin cpio]$ rpmlint cpio-2.6-23.fc6.src.rpm 
W: cpio prereq-use /sbin/rmt
W: cpio prereq-use /sbin/install-info

Use Requires(post) and Requires(preun) instead

W: cpio mixed-use-of-spaces-and-tabs (spaces: line 99, tab: line 3)

If you want to check upgrade candidate too, you can find it at:
http://people.redhat.com/pvrabec/rpms/tar-1.16.1-1.src.rpm

Oops, I'm sorry, ignore comment #2

fixed in cpio-2.6-24.fc7.

Looks good.

One thing though, could you preserve the timestamps when installing files (with install -p or cp -p).

What do you mean? These is "install -c -p -m 0644" used for man page in spec 
file. Is there any place I don't preserve timestamps?

Removal of the bindir, etc definitions at the top of the spec file move the cpio
binary from /bin to /usr/bin which is a bug.

fixed in -25.fc7

Hi Peter,

About the timestamps, the line
install -c -p -m 0644 %{SOURCE1} ${RPM_BUILD_ROOT}%{_mandir}/man1
is redundant, make install already does this, so it can be removed.

test -z "/bin" || mkdir -p -- "/var/tmp/cpio-2.6-25.fc6-root-mockbuild/bin"
  /usr/bin/install -c 'cpio' '/var/tmp/cpio-2.6-25.fc6-root-mockbuild/bin/cpio'

So cpio is installed without preserving the timestamp.

And a new rpmlint error:

Source RPM:
W: cpio mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 86)

I've attached a patch with the fixes.

Created attachment 147709 [details]
Fix timestamps

thnx. Ruben, patch applied.

according to 
"make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install"
should we preserve timestamps on files which were rebuilt?

Preserving timestamps on generated files is pretty useless indeed. But in this case, setting
INSTALL="install -p" takes care of preserving timestamps on the manpages and config files as well.

The only thing the Guidelines say about this is:
When adding file copying commands in the spec file, consider using a command that preserves the files' 
timestamps, eg. cp -p or install -p.

I made a small typo in the patch, could you change the version in the last %changelog entry
from 2.6.26 to 2.6-26?

fixed

Sorry that it took me so long.
I don't see any further blockers so this package is approved.