Bug 225658 - Merge Review: cpuspeed
Merge Review: cpuspeed
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 12:52 EST by Nobody's working on this, feel free to take it
Modified: 2011-08-18 08:10 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2011-08-18 08:10:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 12:52:17 EST
Fedora Merge Review: cpuspeed

Initial Owner: jwilson@redhat.com
Comment 1 Ville Skyttä 2007-02-01 14:49:35 EST

"make CFLAGS=..." is a no-op; the Makefile uses COPTS, thus the build ends up
doing just "gcc -Wall -fno-exceptions -c -O2 cpuspeed.cc".  Just changing CFLAGS
to COPTS makes the build fail here on FC6 i386, though.
Comment 2 Warren Togami 2007-02-01 15:11:25 EST
Needs work then, assigning to owner before the review can go further.  After you
fix this issue, please set fedora-review back to BLANK and reassign back to the
Comment 3 Jarod Wilson 2007-02-04 12:13:32 EST
Okay, I think I *almost* have this one sorted out... I've got the package building on rawhide x86_64 
using most of our stock optflags, save -fexceptions, which is the one that was causing the build to fail 
when switching from CFLAGS= to COPTS= (note that that stock Makefile is set up to pass -fno-
exceptions). I've tweaked things a bit further so the -z bits are only passed during linking, so as to 
suppress some warning messages.

+ make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -fstack-protector 
--param=ssp-buffer-size=4 -m64 -mtune=generic -fpie -pie' LDFLAGS=-Wl,-z,relro,-z,now
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -fstack-protector --param=ssp-
buffer-size=4 -m64 -mtune=generic -fpie -pie -c -O2 cpuspeed.cc
cpuspeed.cc:121: warning: non-local variable '<anonymous struct> speeds [16]' uses anonymous type
cpuspeed.cc: In function 'int main(unsigned int, char**)':
cpuspeed.cc:810: warning: ignoring return value of 'int daemon(int, int)', declared with attribute 
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -fstack-protector --param=ssp-
buffer-size=4 -m64 -mtune=generic -fpie -pie -Wl,-z,relro,-z,now cpuspeed.o -o cpuspeed
+ exit 0

This results in built packages that, at a glance, seem to be functioning correctly. Unfortunately, I'm still 
winding up with no source in the debuginfo package for some reason that is beyond me at the 

Comment 4 Jarod Wilson 2007-02-04 14:22:04 EST
Turns out the lack of source files in my debuginfo is due to my rpm build root's $RPM_BUILD_DIR having a 
shorter path name than /usr/src/debug, which debugedit (called from find-debuginfo.sh) pukes on. With 
a suitably longer build root path, source files are indeed being properly included in -debuginfo now.
Comment 5 Ondrej Vasik 2011-08-18 08:10:53 EDT
as cpuspeed is dead package now, closing WONTFIX...

Note You need to log in before you can comment on or make changes to this bug.