GCC 14 will treat type errors like these as errors: gtk-glue.c: In function 'Fgtk_window_get_position': gtk-glue.c:5321:38: error: passing argument 2 of 'gtk_window_get_position' makes pointer from integer without a cast 5321 | gtk_window_get_position (c_window, c_x, c_y); | ^~~ | | | gint {aka int} In file included from /usr/include/gtk-2.0/gtk/gtkdialog.h:35, from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:33, from gtk-glue.c:4: /usr/include/gtk-2.0/gtk/gtkwindow.h:383:52: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 383 | gint *root_x, | ~~~~~~~~~~~~~^~~~~~ gtk-glue.c:5321:43: error: passing argument 3 of 'gtk_window_get_position' makes pointer from integer without a cast 5321 | gtk_window_get_position (c_window, c_x, c_y); | ^~~ | | | gint {aka int} /usr/include/gtk-2.0/gtk/gtkwindow.h:384:52: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 384 | gint *root_y); | ~~~~~~~~~~~~~^~~~~~ gtk-glue.c: In function 'Fgtk_window_get_frame_dimensions': gtk-glue.c:5895:46: error: passing argument 2 of 'gtk_window_get_frame_dimensions' makes pointer from integer without a cast 5895 | gtk_window_get_frame_dimensions (c_window, c_left, c_top, c_right, c_bottom); | ^~~~~~ | | | gint {aka int} /usr/include/gtk-2.0/gtk/gtkwindow.h:270:60: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 270 | gint *left, | ~~~~~~~~~~~^~~~ gtk-glue.c:5895:54: error: passing argument 3 of 'gtk_window_get_frame_dimensions' makes pointer from integer without a cast 5895 | gtk_window_get_frame_dimensions (c_window, c_left, c_top, c_right, c_bottom); | ^~~~~ | | | gint {aka int} /usr/include/gtk-2.0/gtk/gtkwindow.h:271:60: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 271 | gint *top, | ~~~~~~~~~~~^~~ gtk-glue.c:5895:61: error: passing argument 4 of 'gtk_window_get_frame_dimensions' makes pointer from integer without a cast 5895 | gtk_window_get_frame_dimensions (c_window, c_left, c_top, c_right, c_bottom); | ^~~~~~~ | | | gint {aka int} /usr/include/gtk-2.0/gtk/gtkwindow.h:272:60: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 272 | gint *right, | ~~~~~~~~~~~^~~~~ gtk-glue.c:5895:70: error: passing argument 5 of 'gtk_window_get_frame_dimensions' makes pointer from integer without a cast 5895 | gtk_window_get_frame_dimensions (c_window, c_left, c_top, c_right, c_bottom); | ^~~~~~~~ | | | gint {aka int} /usr/include/gtk-2.0/gtk/gtkwindow.h:273:60: note: expected 'gint *' {aka 'int *'} but argument is of type 'gint' {aka 'int'} 273 | gint *bottom); | ~~~~~~~~~~~^~~~~~ This code looks very broken and like to crash at run time. These function wrappers could probably be removed because clearly no one is calling them. (I don't know if the framework supports output parameters like that.) Reproducible: Always
FEDORA-2024-1811832f13 (rep-gtk-0.90.8.3-20.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1811832f13
FEDORA-2024-1811832f13 (rep-gtk-0.90.8.3-20.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1a0398b1d2 (rep-gtk-0.90.8.3-20.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1a0398b1d2
FEDORA-2024-1a0398b1d2 (rep-gtk-0.90.8.3-20.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-f087801438 (rep-gtk-0.90.8.3-20.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f087801438
Thanks! Has https://src.fedoraproject.org/rpms/rep-gtk/blob/rawhide/f/gcc14-2.patch been submitted upstream?
Not yet, but I will. I'll recheck it before submitting. There are couple of pending warnings left but I think those can't be fixed easily. As far as I know, those functions are mostly unused. Just like you said...
FEDORA-2024-f087801438 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f087801438` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f087801438 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-f087801438 (rep-gtk-0.90.8.3-20.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.