Bug 225700 - Merge Review: docbook-dtds
Merge Review: docbook-dtds
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kamil Dudka
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:28 EST by Nobody's working on this, feel free to take it
Modified: 2010-03-04 02:04 EST (History)
3 users (show)

See Also:
Fixed In Version: docbook-dtds-1.0-52.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-03-04 01:38:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kdudka: fedora‑review+
wtogami: fedora‑cvs+


Attachments (Terms of Use)
fix rpmlint warnings about unapplied patches (1018 bytes, patch)
2010-02-23 07:42 EST, Kamil Dudka
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:28:50 EST
Fedora Merge Review: docbook-dtds

http://cvs.fedora.redhat.com/viewcvs/devel/docbook-dtds/
Initial Owner: twaugh@redhat.com
Comment 1 Ondrej Vasik 2007-07-27 04:10:11 EDT
Package Change Request
======================
Package Name: docbook-dtds
Updated Fedora Owners: ovasik@redhat.com
Comment 2 Kamil Dudka 2010-02-23 07:42:20 EST
Created attachment 395701 [details]
fix rpmlint warnings about unapplied patches
Comment 3 Kamil Dudka 2010-02-23 08:37:30 EST
considered OK
=============
- almost silent rpmlint with the the patch applied:

docbook-dtds.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 299, tab: line 269)
docbook-dtds.noarch: W: dangerous-command-in-%post chmod
docbook-dtds.noarch: W: dangerous-command-in-%postun rm

- sane summary/description
- valid project URL and source URL
- upstream zip archives are match the ones from look-aside cache
- dist tag OK
- license tag OK
- %prep OK
- %clean OK
- %defattr OK
- %files OK
- %doc OK, the hack with cp --parents is IMO a bit subtle, but it works


may be better
=============
- BuildRoot tag should be %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- all explicit (Build)Requires may be eliminated (far beyond Fedora 11)
Comment 4 Ondrej Vasik 2010-03-03 11:00:03 EST
Fixed and built as docbook-dtds-1.0-51.fc14 .
Comment 5 Kamil Dudka 2010-03-03 11:22:35 EST
Thank you for considering the review comments.

I am still getting two rpmlint errors:
docbook-dtds.noarch: E: explicit-lib-dependency libcurl
docbook-dtds.noarch: E: explicit-lib-dependency libcurl

I suggest to fix it as follows:
===================================================================
RCS file: /cvs/extras/rpms/docbook-dtds/devel/docbook-dtds.spec,v
retrieving revision 1.36
diff -u -p -r1.36 docbook-dtds.spec
--- docbook-dtds.spec   3 Mar 2010 15:59:04 -0000       1.36
+++ docbook-dtds.spec   3 Mar 2010 16:21:57 -0000
@@ -33,8 +33,8 @@ Provides: docbook-dtd44-xml = %{version}
 Provides: docbook-dtd45-sgml = %{version}-%{release}
 Provides: docbook-dtd45-xml = %{version}-%{release}
 
-Requires(post): libxml2
-Requires(postun): libxml2
+Requires(post): /usr/bin/xmlcatalog
+Requires(postun): /usr/bin/xmlcatalog
 Requires(post): /bin/chmod
 Requires: sgml-common
 Requires: xml-common
Comment 6 Kamil Dudka 2010-03-03 11:24:40 EST
> docbook-dtds.noarch: E: explicit-lib-dependency libcurl
> docbook-dtds.noarch: E: explicit-lib-dependency libcurl

s/libcurl/libxml2/
Comment 7 Ondrej Vasik 2010-03-03 11:26:12 EST
Fixed in docbook-dtds-1.0-52.fc14 ... thanks.
Comment 8 Kamil Dudka 2010-03-03 11:29:14 EST
Looks sane now.

fedora-review+

Note You need to log in before you can comment on or make changes to this bug.