Fedora Merge Review: docbook-dtds http://cvs.fedora.redhat.com/viewcvs/devel/docbook-dtds/ Initial Owner: twaugh
Package Change Request ====================== Package Name: docbook-dtds Updated Fedora Owners: ovasik
Created attachment 395701 [details] fix rpmlint warnings about unapplied patches
considered OK ============= - almost silent rpmlint with the the patch applied: docbook-dtds.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 299, tab: line 269) docbook-dtds.noarch: W: dangerous-command-in-%post chmod docbook-dtds.noarch: W: dangerous-command-in-%postun rm - sane summary/description - valid project URL and source URL - upstream zip archives are match the ones from look-aside cache - dist tag OK - license tag OK - %prep OK - %clean OK - %defattr OK - %files OK - %doc OK, the hack with cp --parents is IMO a bit subtle, but it works may be better ============= - BuildRoot tag should be %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - all explicit (Build)Requires may be eliminated (far beyond Fedora 11)
Fixed and built as docbook-dtds-1.0-51.fc14 .
Thank you for considering the review comments. I am still getting two rpmlint errors: docbook-dtds.noarch: E: explicit-lib-dependency libcurl docbook-dtds.noarch: E: explicit-lib-dependency libcurl I suggest to fix it as follows: =================================================================== RCS file: /cvs/extras/rpms/docbook-dtds/devel/docbook-dtds.spec,v retrieving revision 1.36 diff -u -p -r1.36 docbook-dtds.spec --- docbook-dtds.spec 3 Mar 2010 15:59:04 -0000 1.36 +++ docbook-dtds.spec 3 Mar 2010 16:21:57 -0000 @@ -33,8 +33,8 @@ Provides: docbook-dtd44-xml = %{version} Provides: docbook-dtd45-sgml = %{version}-%{release} Provides: docbook-dtd45-xml = %{version}-%{release} -Requires(post): libxml2 -Requires(postun): libxml2 +Requires(post): /usr/bin/xmlcatalog +Requires(postun): /usr/bin/xmlcatalog Requires(post): /bin/chmod Requires: sgml-common Requires: xml-common
> docbook-dtds.noarch: E: explicit-lib-dependency libcurl > docbook-dtds.noarch: E: explicit-lib-dependency libcurl s/libcurl/libxml2/
Fixed in docbook-dtds-1.0-52.fc14 ... thanks.
Looks sane now. fedora-review+