Hide Forgot
Fedora Merge Review: docbook-simple http://cvs.fedora.redhat.com/viewcvs/devel/docbook-simple/ Initial Owner: twaugh@redhat.com
Package Change Request ====================== Package Name: docbook-simple Updated Fedora Owners: ovasik@redhat.com
1) rpmlint gave me docbook-simple.noarch: W: dangerous-command-in-%post mv docbook-simple.noarch: W: dangerous-command-in-%postun rm I guess this is needed for this package. 2)change buildroot to standard acceptable one. http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 3)Preserve timestamps http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab 4) defattr should be %defattr (-,root,root,-) I think this should be used. 5) Use macros instead of hard-coded directory names http://fedoraproject.org/wiki/Packaging/Guidelines#head-255d52ff18f82fa184a32946b82ed81e4fd8885a
ok, everything done and built as docbook-simple-1.1-3.fc9 , thanks for review.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. docbook-simple.noarch: W: dangerous-command-in-%post chmod docbook-simple.noarch: W: dangerous-command-in-%postun rm => these messages can be ignored for this package. + source files match upstream. f31c63f121033a72869286d4a0416421 docbook-simple-1.1.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + xml and sgml catalogs are called in post and postun sections. + package docbook-simple-1.1-3.fc8 -> Provides: config(docbook-simple) = 1.1-3.fc8 Requires: config(docbook-simple) = 1.1-3.fc8 docbook-dtds sgml-common + Not a GUI app. APPROVED.