Fedora Merge Review: docbook-style-dsssl http://cvs.fedora.redhat.com/viewcvs/devel/docbook-style-dsssl/ Initial Owner: twaugh
Package Change Request ====================== Package Name: docbook-style-dsssl Updated Fedora Owners: ovasik
considered OK ============= - almost silent rpmlint (only some spelling false alarms) - sane summary/description - valid project URL and source URL - upstream tarball is the same as the one from look-aside cache - md5 hash matches the sources - dist tag OK - license tag OK - %install OK - %clean OK - %files OK - %defattr OK - %doc OK may be better ============= - BuildRoot tag should be %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - explicit Requires are not commented as they should be - missing post/preun dependency on sgml-common
Thanks for review. BuildRoot is harmless, as no longer used - but fixed. Most of the explicit requires no longer needed - as those versions are really ancient now. Dependency added. Fixed and built as docbook-style-dsssl-1.79-10.fc13.
Looks good to me. fedora-review+
Closing.