Bug 225703 – Merge Review: docbook-style-dsssl

Bug 225703 - Merge Review: docbook-style-dsssl

Summary:	Merge Review: docbook-style-dsssl

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Kamil Dudka
QA Contact:	Fedora Package Reviews List
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-31 13:29 EST by Nobody's working on this, feel free to take it
Modified:	2010-02-03 04:48 EST (History)
CC List:	3 users (show)

See Also:
Fixed In Version:	1.79-10.fc13
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2010-02-03 04:48:54 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	kdudka: fedora‑review+ wtogami: fedora‑cvs+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Nobody's working on this, feel free to take it 2007-01-31 13:29:08 EST

Fedora Merge Review: docbook-style-dsssl

http://cvs.fedora.redhat.com/viewcvs/devel/docbook-style-dsssl/
Initial Owner: twaugh@redhat.com

Comment 1 Ondrej Vasik 2007-07-27 04:16:57 EDT

Package Change Request
======================
Package Name: docbook-style-dsssl
Updated Fedora Owners: ovasik@redhat.com

Comment 2 Kamil Dudka 2010-01-26 10:40:38 EST

considered OK
=============
- almost silent rpmlint (only some spelling false alarms)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- %install OK
- %clean OK
- %files OK
- %defattr OK
- %doc OK


may be better
=============
- BuildRoot tag should be %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- explicit Requires are not commented as they should be

- missing post/preun dependency on sgml-common

Comment 3 Ondrej Vasik 2010-02-02 06:18:21 EST

Thanks for review. BuildRoot is harmless, as no longer used - but fixed. Most of the explicit requires no longer needed - as those versions are really ancient now.  Dependency added. Fixed and built as docbook-style-dsssl-1.79-10.fc13.

Comment 4 Kamil Dudka 2010-02-02 06:48:58 EST

Looks good to me.

fedora-review+

Comment 5 Ondrej Vasik 2010-02-03 04:48:54 EST

Closing.

Note You need to log in before you can comment on or make changes to this bug.