Bug 2257062 - Review Request: rust-blake2b_simd - Pure Rust BLAKE2b implementation with dynamic SIMD
Summary: Review Request: rust-blake2b_simd - Pure Rust BLAKE2b implementation with dyn...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/blake2b_simd
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-06 14:35 UTC by Michel Lind
Modified: 2024-01-09 02:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-09 01:45:56 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-01-06 14:35:19 UTC
Spec URL: https://salimma.fedorapeople.org/rust-blake2b_simd.spec
SRPM URL: https://salimma.fedorapeople.org/rust-blake2b_simd-1.0.2-1.fc38.src.rpm

Description:
A pure Rust BLAKE2b implementation with dynamic SIMD.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-06 14:37:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6868279
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257062-rust-blake2b_simd/fedora-rawhide-x86_64/06868279-rust-blake2b_simd/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2024-01-06 16:52:49 UTC
Taking this review

Comment 3 Davide Cavalca 2024-01-06 17:13:35 UTC
This needs rust-constant_time_eq-0.3.0-1.fc40 which isn't in a compose yet, so I used --enablerepo local to validate a build.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-06 21:50:06 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-blake2b_simd

Comment 5 Fedora Update System 2024-01-07 05:21:46 UTC
FEDORA-2024-28835fd54d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d

Comment 6 Fedora Update System 2024-01-07 05:23:48 UTC
FEDORA-2024-16a9ae4035 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035

Comment 7 Fedora Update System 2024-01-08 01:35:44 UTC
FEDORA-2024-28835fd54d has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-28835fd54d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-01-08 02:23:51 UTC
FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-16a9ae4035`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-01-09 01:45:56 UTC
FEDORA-2024-28835fd54d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-01-09 02:51:20 UTC
FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.