Spec URL: https://salimma.fedorapeople.org/rust-sm3.spec SRPM URL: https://salimma.fedorapeople.org/rust-sm3-0.4.2-1.fc38.src.rpm Description: SM3 (OSCCA GM/T 0004-2012) hash function. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6868288 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257063-rust-sm3/fedora-rawhide-x86_64/06868288-rust-sm3/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review
The rust2rpm-generated Summary is a bit weird, it drops SM3 from the start which is not really good here.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines I agree with Fabio, please fix the summary on import. Besides that, it's APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sm3
(In reply to Fabio Valentini from comment #3) > The rust2rpm-generated Summary is a bit weird, it drops SM3 from the start > which is not really good here. Huh, yeah. Will fix. Is this a rust2rpm issue?
FEDORA-2024-28835fd54d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d
FEDORA-2024-16a9ae4035 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035
FEDORA-2024-28835fd54d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-28835fd54d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-16a9ae4035` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-28835fd54d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.