Spec URL: https://trix.fedorapeople.org/hipfft.spec SRPM URL: https://trix.fedorapeople.org/hipfft-6.0.0-1.fc40.src.rpm The package is a WIP, and presented early to show the a change in rocfft. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6868358 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257069-hipfft/fedora-rawhide-x86_64/06868358-hipfft/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://trix.fedorapeople.org/hipfft.spec SRPM URL: https://trix.fedorapeople.org/hipfft-6.0.0-1.fc40.src.rpm The upstream issue was fixed in the 6.0 release branch. The src is pulled from its commit id.
Created attachment 2009363 [details] The .spec file difference from Copr build 6868358 to 6923548
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923548 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257069-hipfft/fedora-rawhide-x86_64/06923548-hipfft/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A few small things: 1. "BuildRequires: clang" to satisfy https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ 2. all the rocm subprojects were consolidated into a single github project and the base url needs to be updated- https://github.com/ROCm/ 3. this is a snapshot (that will eventually be 6.0.1 once that's released) and thus, the version should be 6.0.0.git%{shortcommit} or 6.0.0.%{shortcommit} - https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots I'm still running the test suite but everything is passing so far and I don't anticipate any problems
Spec URL: https://trix.fedorapeople.org/hipfft.spec SRPM URL: https://trix.fedorapeople.org/hipfft-6.0.0.18c75d8-1.fc40.src.rpm For changes. Also changed to autorelease, autochangelog.
Created attachment 2009897 [details] The .spec file difference from Copr build 6923548 to 6943010
Copr build: https://copr.fedorainfracloud.org/coprs/build/6943010 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257069-hipfft/fedora-rawhide-x86_64/06943010-hipfft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM
Oh, I'd suggest putting '-b 2' after %autorelease to make sure that the official builds supersede any review builds but it's not critical.
The Pagure repository was created at https://src.fedoraproject.org/rpms/hipfft