Bug 225707 - Merge Review: dosfstools
Summary: Merge Review: dosfstools
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-31 18:29 UTC by Nobody's working on this, feel free to take it
Modified: 2009-02-04 11:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-02-04 11:02:54 UTC
Type: ---
panemade: fedora-review+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 18:29:56 UTC
Fedora Merge Review: dosfstools

Initial Owner: pvrabec@redhat.com

Comment 1 Ville Skyttä 2007-02-20 22:28:49 UTC
Not a review, but a packaging issue to fix: build produces a useless debuginfo
package due to use of "install -s" in the specfile; dropping the two occurrences
of -s fixes it.

Comment 2 Peter Vrabec 2007-02-26 09:10:30 UTC
fixed in dosfstools-2.11-7.

Comment 3 Fabian Affolter 2008-12-08 10:18:54 UTC
- '/sbin/' should be replaced with a macro -> https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros 

- ChangeLog and COPYING needs to be included in %doc

- 3.0.1 is out ( http://www.daniel-baumann.ch/software/dosfstools/ )

Comment 4 Parag AN(पराग) 2008-12-24 04:27:51 UTC
1)I see latest upstream release is 3.0.1 you can build new package in rawhide.
2) you can include ChangeLog and COPYING by adding
mv COPYING ChangeLog doc/
to %prep

Comment 5 Parag AN(पराग) 2009-01-16 10:18:28 UTC

Comment 6 Peter Vrabec 2009-01-19 10:51:28 UTC

/sbin/ was not replaced, since there is no macro for that. All packages that place their files in /sbin use "/sbin".

I'm removing myself from CC list and assigning kasal as a new maintainer of dosfstools, see:

Comment 7 Parag AN(पराग) 2009-01-20 04:33:43 UTC
As already suggested in comment #4 and from %files section it will not be good to have this package installing 2 directories

That should be either one.
Please update SPEC and build new package.

Best you can do as suggested in comment #4 is to write 
mv COPYING ChangeLog doc/
to %prep

Comment 8 Parag AN(पराग) 2009-01-29 09:15:53 UTC

Comment 9 Stepan Kasal 2009-01-30 14:25:15 UTC
fixed in dosfstools-3.0.1-3

Comment 10 Parag AN(पराग) 2009-02-04 06:45:56 UTC
Thanks for your work.

Note You need to log in before you can comment on or make changes to this bug.