Bug 225707 - Merge Review: dosfstools
Merge Review: dosfstools
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:29 EST by Nobody's working on this, feel free to take it
Modified: 2009-02-04 06:02 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-04 06:02:54 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:29:56 EST
Fedora Merge Review: dosfstools

http://cvs.fedora.redhat.com/viewcvs/devel/dosfstools/
Initial Owner: pvrabec@redhat.com
Comment 1 Ville Skyttä 2007-02-20 17:28:49 EST
Not a review, but a packaging issue to fix: build produces a useless debuginfo
package due to use of "install -s" in the specfile; dropping the two occurrences
of -s fixes it.
http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00339.html
Comment 2 Peter Vrabec 2007-02-26 04:10:30 EST
fixed in dosfstools-2.11-7.
Comment 3 Fabian Affolter 2008-12-08 05:18:54 EST
- '/sbin/' should be replaced with a macro -> https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros 

- ChangeLog and COPYING needs to be included in %doc

- 3.0.1 is out ( http://www.daniel-baumann.ch/software/dosfstools/ )
Comment 4 Parag AN(पराग) 2008-12-23 23:27:51 EST
1)I see latest upstream release is 3.0.1 you can build new package in rawhide.
2) you can include ChangeLog and COPYING by adding
mv COPYING ChangeLog doc/
to %prep
Comment 5 Parag AN(पराग) 2009-01-16 05:18:28 EST
ping?
Comment 6 Peter Vrabec 2009-01-19 05:51:28 EST
done.

/sbin/ was not replaced, since there is no macro for that. All packages that place their files in /sbin use "/sbin".


I'm removing myself from CC list and assigning kasal as a new maintainer of dosfstools, see:
https://admin.fedoraproject.org/pkgdb/packages/name/dosfstools
Comment 7 Parag AN(पराग) 2009-01-19 23:33:43 EST
As already suggested in comment #4 and from %files section it will not be good to have this package installing 2 directories
/usr/share/doc/dosfstools
/usr/share/doc/dosfstools-3.0.1

That should be either one.
Please update SPEC and build new package.

Best you can do as suggested in comment #4 is to write 
mv COPYING ChangeLog doc/
to %prep
Comment 8 Parag AN(पराग) 2009-01-29 04:15:53 EST
ping?
Comment 9 Stepan Kasal 2009-01-30 09:25:15 EST
fixed in dosfstools-3.0.1-3
Comment 10 Parag AN(पराग) 2009-02-04 01:45:56 EST
Thanks for your work.
APPROVED.

Note You need to log in before you can comment on or make changes to this bug.