Fedora Merge Review: dosfstools http://cvs.fedora.redhat.com/viewcvs/devel/dosfstools/ Initial Owner: pvrabec
Not a review, but a packaging issue to fix: build produces a useless debuginfo package due to use of "install -s" in the specfile; dropping the two occurrences of -s fixes it. http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00339.html
fixed in dosfstools-2.11-7.
- '/sbin/' should be replaced with a macro -> https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - ChangeLog and COPYING needs to be included in %doc - 3.0.1 is out ( http://www.daniel-baumann.ch/software/dosfstools/ )
1)I see latest upstream release is 3.0.1 you can build new package in rawhide. 2) you can include ChangeLog and COPYING by adding mv COPYING ChangeLog doc/ to %prep
ping?
done. /sbin/ was not replaced, since there is no macro for that. All packages that place their files in /sbin use "/sbin". I'm removing myself from CC list and assigning kasal as a new maintainer of dosfstools, see: https://admin.fedoraproject.org/pkgdb/packages/name/dosfstools
As already suggested in comment #4 and from %files section it will not be good to have this package installing 2 directories /usr/share/doc/dosfstools /usr/share/doc/dosfstools-3.0.1 That should be either one. Please update SPEC and build new package. Best you can do as suggested in comment #4 is to write mv COPYING ChangeLog doc/ to %prep
fixed in dosfstools-3.0.1-3
Thanks for your work. APPROVED.