Fedora Merge Review: dump http://cvs.fedora.redhat.com/viewcvs/devel/dump/ Initial Owner: atkac
Created attachment 330953 [details] spec file patch - cleanups Please find attached a small patch for the spec which makes rpmlint happier. There are some errors left: rpmlint of dump: dump.x86_64: E: zero-length /etc/dumpdates dump.x86_64: E: explicit-lib-dependency bzip2-libs dump.x86_64: E: explicit-lib-dependency e2fsprogs-libs dump.x86_64: E: explicit-lib-dependency libselinux dump.x86_64: E: explicit-lib-dependency libsepol dump.x86_64: E: explicit-lib-dependency zlib I can understand the need of the zero-length dumpdates, but I do not understand why does the spec say: # This Requires is now mandatory because we only ship static binaries, and # need to ensure the "disk" group is created before installation (#60461) Requires: setup, e2fsprogs-libs, zlib, bzip2-libs, device-mapper Requires: rmt, libselinux, libsepol, glibc but later on you do: %configure --disable-static \ Of course rpmbuild picks all requires automatically, so I guess you should drop either the explicit requires or the --disable-static.
Thanks for specfile patch, it's ok. I removed explicit requires as well so dump-0.4b41-10.fc11 should be sane.
One more thing, probably minor: in the build.log I see: configure: WARNING: unrecognized options: --with-dumpdates Leftover from a previous version ?
(In reply to comment #3) > One more thing, probably minor: in the build.log I see: > > configure: WARNING: unrecognized options: --with-dumpdates > > Leftover from a previous version ? ah, that option has been changed to "--with-dumpdatespath" but we don't need it at all, it is set correctly by default. I commited removal to CVS.
excellent. APPROVED.
Thanks for review.