Bug 225716 - Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 13:31 EST by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-08-01 15:25:49 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
tcallawa: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2007-01-31 13:31:24 EST
Spec URL: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs.spec
SRPM URL: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs-0.1-1.fc7.src.rpm
gnome-screensaver-frogs is an addon screen saver for GNOME Screensaver
that provides a slideshow of freely distributable frog pictures.
Comment 1 Matthias Saou 2007-02-13 13:36:57 EST
You might want to add -p to the install lines, in order to preserve the original
file timestamps between rebuilds.
Also, I see no point in having the %{?dist} tag for this 6MB noarch package, as
it would be better to hardlink it across Fedora releases.

Oh, and... is this package for real? :-)
If it is, I'll take the time to look at it closer and do a proper review ;-)
Comment 2 Matthias Saou 2007-02-25 16:53:07 EST
Hint 1 : In GNOME screensaver, you can select the "Pictures folder" screensaver,
which should allow you to trivially have a slideshow of all pictures in a given
directory, which should pretty much do what you want, without requiring an
entire package.

Hint 2 : The "Pictures folder" screensaver seems pretty broken and/or limited
since it doesn't seem to be configurable from the GUI, nor can one figure out
where the pictures should go in by default.
Comment 3 Tom "spot" Callaway 2007-05-24 13:59:43 EDT
So, yes, I'm for real. I'm aware of the Pictures folder, but I wanted to make
something so other people could get a set of Frog pictures as a screensaver.

This is freely redistributable content which enhances the Fedora user experience.

Comment 5 Jason Tibbitts 2007-07-28 11:27:35 EDT
Is this one really being reviewed?  I see no comments from the person it's
assigned to.
Comment 6 Tom "spot" Callaway 2007-07-28 12:23:57 EDT
I'd really like a review on this. Should take about 12 seconds.
Comment 7 manuel wolfshant 2007-07-29 16:40:43 EDT
- rpmlint checks return: 
# rpmlint ~/gnome-screensaver-frogs-0.2-2.src.rpm
W: gnome-screensaver-frogs invalid-license CC Attribution 2.0/CC
Attribution-ShareAlike 2.0/Public Domain
# rpmlint
W: gnome-screensaver-frogs invalid-license CC Attribution 2.0/CC
Attribution-ShareAlike 2.0/Public Domain
It's the first time I see several licenses listed in the License tag, but since
all of them are GPL compatible and you are the expert in this area, I'll trust you.
- package meets naming guidelines
- package meets packaging guidelines
- license (CC Attribution 2.0/CC Attribution-ShareAlike 2.0/Public Domain ) OK,
text in %doc, matches source, full list of files + corresponding licenses included
- spec file legible, in am. english
- source matches upstream
- nothing to compile, the package is just a collection of pictures
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok [*]
- %clean ok
- macro use consistent
- only content (pictures)
- no need for -docs
- nothing in %doc affects runtime
- the included .desktop file is installed under the gnome screenserver hierarchy

[*] I would have preferred %defaultattr(-,root,root,-)

Comment 8 Lubomir Kundrak 2007-07-30 05:40:49 EDT
I apologize for not reviewing the package for such long time. This is a really
big and complex package that's why it took so long for me.

What was not clear to me was the copyright/license for each of the the photos.
It is not clear who authored which picture, and what is the copying policy
for it.

Second one was kind of a "pseudo-security" issue -- I haven't look at it yet,
but are you sure none of the pictures contain EXIF thumbnail of an uncropped 
or unprocessed photo?
Comment 9 Tom "spot" Callaway 2007-07-30 08:01:10 EDT
There's a README file, which lists the copyright/license for each of the photos,
and the author.

As to the EXIF thumbnail, I didn't even think to check. I'll do that before
Comment 10 Tom "spot" Callaway 2007-08-01 15:25:49 EDT
One of the pictures did have a "PreviewImage" on it, but it was easy enough to

Did my own CVS for this package:

Package Name: gnome-screensaver-frogs
Short Description: GNOME Screensaver Slideshow of Frogs
Owners: tcallawa@redhat.com
Branches: FC-6 F-7 EL-4 EL-5

Built too.

Note You need to log in before you can comment on or make changes to this bug.