W: elilo no-url-tag
W: elilo unversioned-explicit-obsoletes eli
W: elilo buildprereq-use gnu-efi, pciutils-devel

Source and patch file references should %{name} and %{version} (except patches).

Copying of docs in %build should preserve everything (-a).

If possible, pass the %{?_smp_mflags} to make in the %build section.  If the
make can be paralle for a package, it should be.

In the %install section, use path macros when appropriate (e.g., macros for
/usr/share, /usr/share/man, /usr/sbin, and so on).

%defattr in %files should be %defattr(-,root,root,-)

/usr/sbin in %files section should be referenced with %{_sbindir}

Personal opinion: %{buildroot} looks nicer than $RPM_BUILD_ROOT

Also, BuildRoot should be the really long thing too:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed everything except the eli obsoletes warning (because I have no idea about
the history of these packages.  Too bad I can't actually build a new package
with these fixes now that we ripped all the ia64 out of the build system.  Let's
just assume it builds.

Sounds good.  What about doing a 'make srpm' and then doing a brew scratch build
in dist-5E?

Built successfully.

Don't forget to set fedora-review to '+' if this was approved.