Bug 2257307 - Review Request: rust-cedarwood - Efficiently-updatable double-array trie in Rust (ported from cedar)
Summary: Review Request: rust-cedarwood - Efficiently-updatable double-array trie in R...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cedarwood
Whiteboard:
Depends On:
Blocks: 2254775
TreeView+ depends on / blocked
 
Reported: 2024-01-08 18:10 UTC by Albert Larsan
Modified: 2024-01-22 20:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-22 20:12:15 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Albert Larsan 2024-01-08 18:10:44 UTC
Spec URL: https://albertlarsan68.fedorapeople.org/packages/rust-cedarwood/rust-cedarwood.spec
SRPM URL: https://albertlarsan68.fedorapeople.org/packages/rust-cedarwood/rust-cedarwood-0.4.6-1.fc40.src.rpm

Description:
Efficiently-updatable double-array trie in Rust (ported from cedar).

Fedora Account System Username: albertlarsan68

Transitive dependency for rust-mdbook

Comment 1 Fedora Review Service 2024-01-08 18:11:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6872548
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257307-rust-cedarwood/srpm-builds/06872548/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Albert Larsan 2024-01-08 18:14:36 UTC
[fedora-review-service-build] The `fedora-create-review` tool doesn't create directories with the right permissions...

Comment 3 Fedora Review Service 2024-01-08 18:21:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6872651
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257307-rust-cedarwood/fedora-rawhide-x86_64/06872651-rust-cedarwood/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-cedarwood
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Michel Lind 2024-01-09 01:05:08 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Update System 2024-01-22 20:07:47 UTC
FEDORA-2024-ad4f33b72a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad4f33b72a

Comment 6 Fedora Update System 2024-01-22 20:12:15 UTC
FEDORA-2024-ad4f33b72a has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.