Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_csplit.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_csplit-0.0.23-1.fc38.src.rpm Description: Csplit ~ (uutils) Output pieces of FILE separated by PATTERN(s) to files 'xx00', 'xx01', ..., and output byte counts of each piece to standard output. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6877087 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257471-rust-uu_csplit/fedora-rawhide-x86_64/06877087-rust-uu_csplit/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two minor issues: - remove the stray "FIXME" comment from the spec file - drop the parentheses around the "(MIT OR Apache-2.0) AND Unicode-DFS-2016" term in the license tag and de-duplicate "MIT OR Apache-2.0) - the "AND" operator is commutative and associative, so the additional parentheses (and the additional copy of "MIT OR Apache-2.0" are redundant.
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_csplit.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_csplit-0.0.23-1.fc38.src.rpm - FIXME line removed - fixed license, dedup "MIT OR Apache-2.0"
Created attachment 2007985 [details] The .spec file difference from Copr build 6877087 to 6877645
Copr build: https://copr.fedorainfracloud.org/coprs/build/6877645 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257471-rust-uu_csplit/fedora-rawhide-x86_64/06877645-rust-uu_csplit/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me. Thanks! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_csplit
FEDORA-2024-13d4b7079a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-13d4b7079a
FEDORA-2024-13d4b7079a has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-69f6136efd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-69f6136efd
FEDORA-2024-b693f3736d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b693f3736d
FEDORA-2024-b693f3736d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b693f3736d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b693f3736d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-69f6136efd has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-69f6136efd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-69f6136efd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b693f3736d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-69f6136efd has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.