Bug 2257473 - Review Request: rust-uu_cut - cut ~ (uutils) display byte/field columns of input lines
Summary: Review Request: rust-uu_cut - cut ~ (uutils) display byte/field columns of in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/uu_cut
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-09 20:12 UTC by Michel Lind
Modified: 2024-01-21 04:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-12 17:24:26 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6877092 to 6877640 (659 bytes, patch)
2024-01-10 02:46 UTC, Fedora Review Service
no flags Details | Diff

Description Michel Lind 2024-01-09 20:12:00 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_cut.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_cut-0.0.23-1.fc38.src.rpm

Description:
cut ~ (uutils) display byte/field columns of input lines.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-09 20:21:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6877092
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257473-rust-uu_cut/fedora-rawhide-x86_64/06877092-rust-uu_cut/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-09 23:19:29 UTC
Two minor issues:

- remove the stray "FIXME" comment from the spec file
- drop the parentheses around the "(MIT OR Apache-2.0) AND Unicode-DFS-2016" term in the license tag and de-duplicate "MIT OR Apache-2.0) - the "AND" operator is commutative and associative, so the additional parentheses (and the additional copy of "MIT OR Apache-2.0" are redundant.

Comment 3 Michel Lind 2024-01-10 02:36:25 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_cut.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_cut-0.0.23-1.fc38.src.rpm

Fixed, thanks

- FIXME line removed
- simplified parentheses and dedup (MIT OR Apache-2.0)

Comment 4 Fedora Review Service 2024-01-10 02:46:14 UTC
Created attachment 2007984 [details]
The .spec file difference from Copr build 6877092 to 6877640

Comment 5 Fedora Review Service 2024-01-10 02:46:17 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6877640
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257473-rust-uu_cut/fedora-rawhide-x86_64/06877640-rust-uu_cut/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2024-01-10 22:19:51 UTC
Looks good to me, thank you!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-01-12 17:09:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_cut

Comment 8 Fedora Update System 2024-01-12 17:22:39 UTC
FEDORA-2024-d0c4668d46 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d0c4668d46

Comment 9 Fedora Update System 2024-01-12 17:24:26 UTC
FEDORA-2024-d0c4668d46 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-01-12 18:02:23 UTC
FEDORA-2024-d8e312942e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8e312942e

Comment 11 Fedora Update System 2024-01-13 17:41:23 UTC
FEDORA-2024-d8e312942e has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d8e312942e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8e312942e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-13 18:19:27 UTC
FEDORA-2024-2833c86969 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2833c86969 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2833c86969

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-01-21 03:30:41 UTC
FEDORA-2024-d8e312942e has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-01-21 04:21:36 UTC
FEDORA-2024-2833c86969 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.