Bug 2257476 - Review Request: rust-gcd - Calculate the greatest common divisor
Summary: Review Request: rust-gcd - Calculate the greatest common divisor
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gcd
Whiteboard:
Depends On:
Blocks: 2257482
TreeView+ depends on / blocked
 
Reported: 2024-01-09 20:25 UTC by Michel Lind
Modified: 2024-01-19 03:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-10 15:39:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-01-09 20:25:12 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-gcd.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-gcd-2.3.0-1.fc38.src.rpm

Description:
Calculate the greatest common divisor.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-09 20:31:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6877104
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257476-rust-gcd/fedora-rawhide-x86_64/06877104-rust-gcd/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-09 23:34:36 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-01-10 02:26:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gcd

Comment 4 Fedora Update System 2024-01-10 03:08:04 UTC
FEDORA-2024-a05cf43a91 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a05cf43a91

Comment 5 Fedora Update System 2024-01-11 01:39:59 UTC
FEDORA-2024-d8abdbd552 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d8abdbd552 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8abdbd552

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-01-11 02:08:56 UTC
FEDORA-2024-a05cf43a91 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a05cf43a91 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a05cf43a91

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-01-19 02:41:09 UTC
FEDORA-2024-d8abdbd552 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-01-19 03:24:10 UTC
FEDORA-2024-a05cf43a91 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.