Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_dircolors.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_dircolors-0.0.23-1.fc38.src.rpm Description: Dircolors ~ (uutils) display commands to set LS_COLORS. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6877155 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257498-rust-uu_dircolors/fedora-rawhide-x86_64/06877155-rust-uu_dircolors/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package looks perfect to me, with one exception: The src/colors.rs file contains a "database" with this license header: > # LS_COLORS environment variable used by GNU ls with the --color option. > # Copyright (C) 1996-2022 Free Software Foundation, Inc. > # Copying and distribution of this file, with or without modification, > # are permitted provided the copyright notice and this notice are preserved. I don't know what copyright notice this refers to, but it appears to not be included.
(In reply to Fabio Valentini from comment #2) > Package looks perfect to me, with one exception: > > The src/colors.rs file contains a "database" with this license header: > > > # LS_COLORS environment variable used by GNU ls with the --color option. > > # Copyright (C) 1996-2022 Free Software Foundation, Inc. > > # Copying and distribution of this file, with or without modification, > > # are permitted provided the copyright notice and this notice are preserved. > > I don't know what copyright notice this refers to, but it appears to not be > included. good catch. Looks like colors.rs is generated by calling GNU dircolors itself and... manually tweaking the file until the tests pass. Ugh: https://github.com/uutils/coreutils/blob/main/src/uu/dircolors/README.md So I guess the best path forward is to ask uu_dircolors to include the coreutils LICENSE? so uu_dircolors' license would have to be ... MIT AND GPL-3.0-or-later I suppose.
GNU dircolors: https://github.com/coreutils/coreutils/blob/master/src/dircolors.c
Updated spec and SRPM. Per upstream they no longer use GNU dircolors in the upcoming 0.0.24, and think colors.rs is not necessarily GPL licensed but while waiting for that to ship we might as well include the GPL text for now. [fedora-review-service-build]
Created attachment 2010326 [details] The .spec file difference from Copr build 6877155 to 6947616
Copr build: https://copr.fedorainfracloud.org/coprs/build/6947616 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257498-rust-uu_dircolors/fedora-rawhide-x86_64/06947616-rust-uu_dircolors/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Following the upstream discussion, it sounds like the license header and README were wrong anyway? It's also "just" about data (and not code) that's not exclusively used in "coreutils dircolors", so from my perspective it would be better to drop the GPL license text and the GPL-3.0-or-later identifier to match upstream intentions. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged (v0.0.23 vs. v0.0.24, but this is fine temporarily) - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_dircolors
FEDORA-2024-7f3972c04f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f3972c04f
FEDORA-2024-7f3972c04f has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-13179d7600 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-13179d7600
FEDORA-2024-889c3ba03e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-889c3ba03e
FEDORA-2024-13179d7600 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-13179d7600 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-13179d7600 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-889c3ba03e has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-889c3ba03e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-889c3ba03e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-889c3ba03e has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-13179d7600 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.