Fedora Merge Review: finger http://cvs.fedora.redhat.com/viewcvs/devel/finger/ Initial Owner: rvokal
* RPM name is OK * Source bsd-finger-0.17.tar.gz is the same as upstream * Builds fine in mock * File list of finger-server looks OK * File list of finger looks OK * Config files of finger-server looks OK * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc should not be included (wiki: PackagingGuidelines#Exceptions) * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * Encoding should be UTF-8 * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Rpmlint is not silent: Source RPM: W: finger summary-ended-with-dot The finger client. E: finger tag-not-utf8 %changelog W: finger no-url-tag E: finger non-utf8-spec-file finger.spec W: finger mixed-use-of-spaces-and-tabs (spaces: line 62, tab: line 88) rpmlint of finger-server: W: finger-server summary-ended-with-dot The finger daemon. E: finger-server tag-not-utf8 %changelog W: finger-server no-url-tag E: finger-server non-readable /usr/sbin/in.fingerd 0711 E: finger-server non-standard-executable-perm /usr/sbin/in.fingerd 0711 rpmlint of finger-server: is it OK ? (press Enter if yes, or else type your comment below) rpmlint of finger: W: finger summary-ended-with-dot The finger client. E: finger tag-not-utf8 %changelog W: finger no-url-tag
All of the above except of URL which is unknown should be fixed in finger-0.17-34. Also I've realized that dist tag was missing in the spec. Would be great to check for that as well.
Ah, great. Do you have a url for the new version? It's not avaliable on cvs.fedora.redhat.com yet.
It's in rawhide, built right now.
Perfect, I don't see any blockers. But please consider preserving timestamps with install -p or cp -p when installing files in the next version. This package is approved.
Assigning ticket to myself as per http://fedoraproject.org/wiki/PackageReviewProcess