Fedora Merge Review: firstboot http://cvs.fedora.redhat.com/viewcvs/devel/firstboot/ Initial Owner: clumens
W: firstboot unversioned-explicit-obsoletes anaconda-reconfig E: firstboot no-cleaning-of-buildroot %install The Source field should contain the URL to the downloadable source or a comment like this above it: # This is a Red Hat maintained package which is specific to # our distribution. Thus the source is only available from # within this srpm. Should pass %{?_smp_mflags} to make in the %build target if that works. Package guidelines stuff. Personal opinion: in the %post scriptlet, put then on the same line as if with a semi separating it...like the other scriptlets.
Fixed everything except the unversioned obsoletes warning.
Looks good. I forgot the following. Need: Requires(post): chkconfig Requires(preun): chkconfig
Fixed.
Please don't forget to set fedora-review to '+' if this was approved.