Fedora Merge Review: fonts-ISO8859-2 http://cvs.fedora.redhat.com/viewcvs/devel/fonts-ISO8859-2/ Initial Owner: majain
I think Jens can be good Reviewer for this package. Removing myself from review.
I am not able to verify upstream source as source URL is not working. Not sure what we can do where upstream is no longer available for older packages.
Created attachment 327310 [details] This is modified spec file for fonts-ISO8859-2.spec
Created attachment 327312 [details] This is modified spec file for fonts-ISO8859-2.spec
Rahul, Can you apply new spec in rawhide with excluding -f to fc-cache as its not needed?
Almost more than one month no response from package maintainer. And looks like I also lost now interest in this package.
Rahul, could you apply the above suggested changes please to keep the review moving?
Currently, I have modified spec file to http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec
Created attachment 413737 [details] build.log mock rebuild failed: RPM build errors: File must begin with "/": %{_fontbasedir}ISO8859-2 File must begin with "/": %{_fontbasedir}ISO8859-2/misc File must begin with "/": %{_fontbasedir}ISO8859-2/misc/*.gz File must begin with "/": %{_fontbasedir}ISO8859-2/misc/fonts.alias File must begin with "/": %{_fontbasedir}ISO8859-2/misc/fonts.dir I guess you need to add BuildRequires: fontpackages-devel or define own _fontbasedir to get it fixed.
updated package SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-23.fc13.src.rpm I think there can be many changes happen to spec so I will not bump the release each time. If it looks confusing please tell me and will then provided bumped SPEC and SRPM.
You'd better using _fontdir instead of the own fontdir defined in the spec. otherwise it would ends up to put files under the unexpected path such as /usr/share/fontsISO8859-2.
updated package SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-23.fc13.src.rpm Scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2186907
updated package SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-23.fc13.src.rpm Scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2186969
rpmlint reported: ISO8859-2-100dpi-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/100dpi/fonts.alias ISO8859-2-75dpi-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/75dpi/fonts.alias ISO8859-2-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/misc/fonts.alias ISO8859-2-fonts.src:222: W: macro-in-%changelog %{_fontbasedir} ISO8859-2-fonts.src:168: W: mixed-use-of-spaces-and-tabs (spaces: line 168, tab: line 63) Aside from that, please be aware of %{_fontbasedir}%{fontname} nearly equal to %{_fontdir}. so %{_fontdir}%{fontname} in %post script is wrong.
updated package SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-24.fc13.src.rpm Scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2187095
Sorry, one more fix is required. the package doesn't own /usr/share/fonts/ISO8859-2
updated package SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-24.fc13.src.rpm Scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2191463
Review results: + rpmlint result: ISO8859-2-100dpi-fonts.noarch: W: spelling-error Summary(en_US) dpi -> dip, pi, dpt ISO8859-2-100dpi-fonts.noarch: W: spelling-error %description -l en_US dpi -> dip, pi, dpt ISO8859-2-100dpi-fonts.noarch: W: no-url-tag ISO8859-2-100dpi-fonts.noarch: W: no-documentation ISO8859-2-75dpi-fonts.noarch: W: spelling-error Summary(en_US) dpi -> dip, pi, dpt ISO8859-2-75dpi-fonts.noarch: W: spelling-error %description -l en_US dpi -> dip, pi, dpt ISO8859-2-75dpi-fonts.noarch: W: no-url-tag ISO8859-2-75dpi-fonts.noarch: W: no-documentation ISO8859-2-fonts.src: W: no-url-tag ISO8859-2-fonts.src: W: invalid-url Source0: ISO8859-2-bdf.tar.gz ISO8859-2-fonts-common.noarch: W: no-url-tag ISO8859-2-misc-fonts.noarch: W: no-url-tag ISO8859-2-misc-fonts.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 13 warnings. + the package met the Packaging Naming Guidelines. + the spec file name matches the base package %{name}. + the package met the Packaging Guidelines. + the license is OSS-compatible. + License tag matches the actual license. _ no license file provided by upstream. + the spec file is written in American English. + the spec file is legible. _ according to the comment in the spec file, the upstream link is dead. + the package is buildable on mock. + the package provides noarch only. + the package has the certain BuildRequires. _ no locales files provided. _ no shared libraries provided. + the package owns all directories in the package without duplicates. + no duplicates in %files. + files in the package has certain permissions. + the package consistently use macros. + the package contains permissable content. _ no large documentation files provided. + %doc contains the release notes only. _ no header files provided. _ no static libraries provided. _ no desktop files provided. + all filenames in rpm is valid UTF-8. APPROVED.
Thanks for the review! here is updated package. SPEC:http://paragn.fedorapeople.org/fedora-work/SPECS/iso8859-2-fonts.spec SRPM:http://paragn.fedorapeople.org/fedora-work/SRPMS/iso8859-2-fonts-1.0-24.fc13.src.rpm Scratch build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2193389
New Package CVS Request ======================= Package Name: iso8859-2-fonts Short Description: Central European language fonts for the X Window System Owners: pnemade Branches: F-13 InitialCC: i18n-team, fonts-sig
cvs done