Bug 225764 - Merge Review: fonts-ISO8859-2
Merge Review: fonts-ISO8859-2
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Akira TAGOH
Fedora Extras Quality Assurance
:
Depends On: 491976
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:39 EST by Nobody's working on this, feel free to take it
Modified: 2010-05-20 06:06 EDT (History)
6 users (show)

See Also:
Fixed In Version: iso8859-2-fonts-1.0-24.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-05-20 06:06:14 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tagoh: fedora‑review+
huzaifas: fedora‑cvs+


Attachments (Terms of Use)
This is modified spec file for fonts-ISO8859-2.spec (8.04 KB, application/octet-stream)
2008-12-18 04:25 EST, Parag AN(पराग)
no flags Details
This is modified spec file for fonts-ISO8859-2.spec (8.04 KB, text/plain)
2008-12-18 04:27 EST, Parag AN(पराग)
no flags Details
build.log (6.54 KB, application/octet-stream)
2010-05-13 08:24 EDT, Akira TAGOH
no flags Details

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:39:14 EST
Fedora Merge Review: fonts-ISO8859-2

http://cvs.fedora.redhat.com/viewcvs/devel/fonts-ISO8859-2/
Initial Owner: majain@redhat.com
Comment 1 Parag AN(पराग) 2007-09-07 04:31:40 EDT
I think Jens can be good Reviewer for this package. 
Removing myself from review.
Comment 2 Parag AN(पराग) 2008-12-18 04:23:24 EST
I am not able to verify upstream source as source URL is not working. Not sure what we can do where upstream is no longer available for older packages.
Comment 3 Parag AN(पराग) 2008-12-18 04:25:42 EST
Created attachment 327310 [details]
This is modified spec file for fonts-ISO8859-2.spec
Comment 4 Parag AN(पराग) 2008-12-18 04:27:11 EST
Created attachment 327312 [details]
This is modified spec file for fonts-ISO8859-2.spec
Comment 5 Parag AN(पराग) 2008-12-19 00:29:05 EST
Rahul, 
   Can you apply new spec in rawhide with excluding -f to fc-cache as its not needed?
Comment 6 Parag AN(पराग) 2009-02-03 09:36:48 EST
Almost more than one month no response from package maintainer. And looks like I also lost now interest in this package.
Comment 7 Jens Petersen 2009-02-05 03:44:05 EST
Rahul, could you apply the above suggested changes please to keep the review moving?
Comment 8 Parag Nemade 2010-05-13 06:12:37 EDT
Currently, I have modified spec file to http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec
Comment 9 Akira TAGOH 2010-05-13 08:24:32 EDT
Created attachment 413737 [details]
build.log

mock rebuild failed:
RPM build errors:
    File must begin with "/": %{_fontbasedir}ISO8859-2
    File must begin with "/": %{_fontbasedir}ISO8859-2/misc
    File must begin with "/": %{_fontbasedir}ISO8859-2/misc/*.gz
    File must begin with "/": %{_fontbasedir}ISO8859-2/misc/fonts.alias
    File must begin with "/": %{_fontbasedir}ISO8859-2/misc/fonts.dir

I guess you need to add BuildRequires: fontpackages-devel or define own _fontbasedir to get it fixed.
Comment 10 Parag Nemade 2010-05-13 23:33:40 EDT
updated package
SPEC:- http://paragn.fedorapeople.org/fedora-work/SPECS/ISO8859-2-fonts.spec
SRPM:- http://paragn.fedorapeople.org/fedora-work/SRPMS/ISO8859-2-fonts-1.0-23.fc13.src.rpm

I think there can be many changes happen to spec so I will not bump the release each time. If it looks confusing please tell me and will then provided bumped SPEC and SRPM.
Comment 11 Akira TAGOH 2010-05-14 02:08:33 EDT
You'd better using _fontdir instead of the own fontdir defined in the spec. otherwise it would ends up to put files under the unexpected path such as /usr/share/fontsISO8859-2.
Comment 14 Akira TAGOH 2010-05-14 03:20:20 EDT
rpmlint reported:
ISO8859-2-100dpi-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/100dpi/fonts.alias
ISO8859-2-75dpi-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/75dpi/fonts.alias
ISO8859-2-fonts.noarch: E: file-in-usr-marked-as-conffile /usr/share/fonts/ISO8859-2/misc/fonts.alias
ISO8859-2-fonts.src:222: W: macro-in-%changelog %{_fontbasedir}
ISO8859-2-fonts.src:168: W: mixed-use-of-spaces-and-tabs (spaces: line 168, tab: line 63)

Aside from that, please be aware of %{_fontbasedir}%{fontname} nearly equal to %{_fontdir}. so %{_fontdir}%{fontname} in %post script is wrong.
Comment 16 Akira TAGOH 2010-05-16 23:33:51 EDT
Sorry, one more fix is required. the package doesn't own /usr/share/fonts/ISO8859-2
Comment 18 Akira TAGOH 2010-05-17 04:15:26 EDT
Review results:
+ rpmlint result:
  ISO8859-2-100dpi-fonts.noarch: W: spelling-error Summary(en_US) dpi -> dip, pi, dpt
  ISO8859-2-100dpi-fonts.noarch: W: spelling-error %description -l en_US dpi -> dip, pi, dpt
  ISO8859-2-100dpi-fonts.noarch: W: no-url-tag
  ISO8859-2-100dpi-fonts.noarch: W: no-documentation
  ISO8859-2-75dpi-fonts.noarch: W: spelling-error Summary(en_US) dpi -> dip, pi, dpt
  ISO8859-2-75dpi-fonts.noarch: W: spelling-error %description -l en_US dpi -> dip, pi, dpt
  ISO8859-2-75dpi-fonts.noarch: W: no-url-tag
  ISO8859-2-75dpi-fonts.noarch: W: no-documentation
  ISO8859-2-fonts.src: W: no-url-tag
  ISO8859-2-fonts.src: W: invalid-url Source0: ISO8859-2-bdf.tar.gz
  ISO8859-2-fonts-common.noarch: W: no-url-tag
  ISO8859-2-misc-fonts.noarch: W: no-url-tag
  ISO8859-2-misc-fonts.noarch: W: no-documentation
  5 packages and 0 specfiles checked; 0 errors, 13 warnings.

+ the package met the Packaging Naming Guidelines.
+ the spec file name matches the base package %{name}.
+ the package met the Packaging Guidelines.
+ the license is OSS-compatible.
+ License tag matches the actual license.
_ no license file provided by upstream.
+ the spec file is written in American English.
+ the spec file is legible.
_ according to the comment in the spec file, the upstream link is dead.
+ the package is buildable on mock.
+ the package provides noarch only.
+ the package has the certain BuildRequires.
_ no locales files provided.
_ no shared libraries provided.
+ the package owns all directories in the package without duplicates.
+ no duplicates in %files.
+ files in the package has certain permissions.
+ the package consistently use macros.
+ the package contains permissable content.
_ no large documentation files provided.
+ %doc contains the release notes only.
_ no header files provided.
_ no static libraries provided.
_ no desktop files provided.
+ all filenames in rpm is valid UTF-8.

APPROVED.
Comment 20 Parag Nemade 2010-05-18 01:32:22 EDT
New Package CVS Request
=======================
Package Name: iso8859-2-fonts
Short Description: Central European language fonts for the X Window System
Owners: pnemade
Branches: F-13
InitialCC: i18n-team, fonts-sig
Comment 21 Huzaifa S. Sidhpurwala 2010-05-18 02:24:39 EDT
cvs done

Note You need to log in before you can comment on or make changes to this bug.