Bug 225773 - Merge Review: f-spot
Summary: Merge Review: f-spot
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 18:40 UTC by Nobody's working on this, feel free to take it
Modified: 2010-12-15 07:21 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-12-15 07:21:31 UTC
Type: ---
Embargoed:
panemade: fedora-review+

Attachments (Terms of Use)
spec cleanup (3.27 KB, patch)
2010-10-25 05:13 UTC, Parag AN(पराग) 		no flags Details | Diff
View All

Description Nobody's working on this, feel free to take it 2007-01-31 18:40:26 UTC 
Fedora Merge Review: f-spot

http://cvs.fedora.redhat.com/viewcvs/devel/f-spot/
Initial Owner: caillon
Comment 1 Parag AN(पराग) 2007-03-01 12:28:36 UTC 
rpmlint reported invalid desktop files
Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop
More on how to install .desktop files in SPEC is at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

Kindly update SPEC.
Comment 2 Parag AN(पराग) 2007-03-30 13:24:48 UTC 
any updates?
Comment 3 Martin Jürgens 2008-05-29 08:50:26 UTC 
Isn't F-Spot available in Fedora now?
Comment 4 Rex Dieter 2008-05-29 12:53:11 UTC 
Martin, yes this is a merge review (for previous Core packages that never had 
a formal review).
Comment 5 Christian Krause 2010-10-13 20:08:58 UTC 
(In reply to comment #1)
> rpmlint reported invalid desktop files
> Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop
> More on how to install .desktop files in SPEC is at
> http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

These problems are solved long time ago. ;-)
Comment 6 Parag AN(पराग) 2010-10-25 05:13:10 UTC 
Created attachment 455392 [details]
spec cleanup


spec cleanup patch. Please don't commit this as it is.  I have used Packaging guidelines to cleanup this package.

Also saw some rpmlint errors

f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/f-spot.exe.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Cms.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Core.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Gui.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Utils.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.Gui.dll.config


Also, you need to add comment in spec for which part of code is in licenses given in license tag.


Can maintainer please fix all above issues?
Comment 7 Parag AN(पराग) 2010-12-08 10:10:53 UTC 
chkr ping
Comment 8 Christian Krause 2010-12-12 17:04:42 UTC 
Sorry for the delay.

Please see git for the changes to the spec file:

http://pkgs.fedoraproject.org/gitweb/?p=f-spot.git;a=blobdiff;f=f-spot.spec;h=7659678c4b43817180038aed2d9a58e47d71b6ee;hp=1c8a502c1d7722744b65c25d8a23d3aab2f67b96;hb=3c719fff3bae48ebeb2f233207a56b6311e47b6a;hpb=8224187cd0ec6b137061cc505671c149ce3d68e7
Comment 9 Parag AN(पराग) 2010-12-13 03:44:11 UTC 
Looks good now. Is this update built for rawhide?
Comment 10 Christian Krause 2010-12-13 20:32:54 UTC 
(In reply to comment #9)
> Looks good now. Is this update built for rawhide?

Yes, done:
http://koji.fedoraproject.org/koji/buildinfo?buildID=208945
Comment 11 Parag AN(पराग) 2010-12-15 07:21:31 UTC 
Thanks. APPROVED.
Note You need to log in before you can comment on or make changes to this bug.