Hide Forgot
Fedora Merge Review: f-spot http://cvs.fedora.redhat.com/viewcvs/devel/f-spot/ Initial Owner: caillon@redhat.com
rpmlint reported invalid desktop files Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop More on how to install .desktop files in SPEC is at http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 Kindly update SPEC.
any updates?
Isn't F-Spot available in Fedora now?
Martin, yes this is a merge review (for previous Core packages that never had a formal review).
(In reply to comment #1) > rpmlint reported invalid desktop files > Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop > More on how to install .desktop files in SPEC is at > http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 These problems are solved long time ago. ;-)
Created attachment 455392 [details] spec cleanup spec cleanup patch. Please don't commit this as it is. I have used Packaging guidelines to cleanup this package. Also saw some rpmlint errors f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/f-spot.exe.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Cms.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Core.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Gui.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Utils.dll.config f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.Gui.dll.config Also, you need to add comment in spec for which part of code is in licenses given in license tag. Can maintainer please fix all above issues?
chkr ping
Sorry for the delay. Please see git for the changes to the spec file: http://pkgs.fedoraproject.org/gitweb/?p=f-spot.git;a=blobdiff;f=f-spot.spec;h=7659678c4b43817180038aed2d9a58e47d71b6ee;hp=1c8a502c1d7722744b65c25d8a23d3aab2f67b96;hb=3c719fff3bae48ebeb2f233207a56b6311e47b6a;hpb=8224187cd0ec6b137061cc505671c149ce3d68e7
Looks good now. Is this update built for rawhide?
(In reply to comment #9) > Looks good now. Is this update built for rawhide? Yes, done: http://koji.fedoraproject.org/koji/buildinfo?buildID=208945
Thanks. APPROVED.