Bug 225773 - Merge Review: f-spot
Merge Review: f-spot
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:40 EST by Nobody's working on this, feel free to take it
Modified: 2010-12-15 02:21 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-12-15 02:21:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
spec cleanup (3.27 KB, patch)
2010-10-25 01:13 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:40:26 EST
Fedora Merge Review: f-spot

http://cvs.fedora.redhat.com/viewcvs/devel/f-spot/
Initial Owner: caillon@redhat.com
Comment 1 Parag AN(पराग) 2007-03-01 07:28:36 EST
rpmlint reported invalid desktop files
Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop
More on how to install .desktop files in SPEC is at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

Kindly update SPEC.
Comment 2 Parag AN(पराग) 2007-03-30 09:24:48 EDT
any updates?
Comment 3 Martin Jürgens 2008-05-29 04:50:26 EDT
Isn't F-Spot available in Fedora now?
Comment 4 Rex Dieter 2008-05-29 08:53:11 EDT
Martin, yes this is a merge review (for previous Core packages that never had 
a formal review).
Comment 5 Christian Krause 2010-10-13 16:08:58 EDT
(In reply to comment #1)
> rpmlint reported invalid desktop files
> Use desktop-file-validate on f-spot.desktop and f-spot-view.desktop
> More on how to install .desktop files in SPEC is at
> http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

These problems are solved long time ago. ;-)
Comment 6 Parag AN(पराग) 2010-10-25 01:13:10 EDT
Created attachment 455392 [details]
spec cleanup


spec cleanup patch. Please don't commit this as it is.  I have used Packaging guidelines to cleanup this package.

Also saw some rpmlint errors

f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/f-spot.exe.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Cms.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Core.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Gui.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/FSpot.Utils.dll.config
f-spot.x86_64: E: script-without-shebang /usr/lib64/f-spot/Hyena.Gui.dll.config


Also, you need to add comment in spec for which part of code is in licenses given in license tag.


Can maintainer please fix all above issues?
Comment 7 Parag AN(पराग) 2010-12-08 05:10:53 EST
chkr ping
Comment 9 Parag AN(पराग) 2010-12-12 22:44:11 EST
Looks good now. Is this update built for rawhide?
Comment 10 Christian Krause 2010-12-13 15:32:54 EST
(In reply to comment #9)
> Looks good now. Is this update built for rawhide?

Yes, done:
http://koji.fedoraproject.org/koji/buildinfo?buildID=208945
Comment 11 Parag AN(पराग) 2010-12-15 02:21:31 EST
Thanks. APPROVED.

Note You need to log in before you can comment on or make changes to this bug.