Fedora Merge Review: gconf-editor
Initial Owner: email@example.com
[mclasen@localhost devel]$ rpmlint i386/gconf-editor-2.20.0-2.fc9.i386.rpm
gconf-editor.i386: W: non-conffile-in-etc /etc/gconf/schemas/gconf-editor.schemas
which is generally accepted practise for schema files.
Everything checks out as far as I can tell. While it isn't mandatory, you might want to query upstream about including the text of the GFDL in their source tarball (COPYING-DOCS) so it can go in the package. Consider also using %global over %define.
A full review is attached.
Created attachment 430532 [details]
Review of gconf-editor-2.30.0-1