Bug 225780 - Merge Review: gconf-editor
Merge Review: gconf-editor
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Garrett Holmstrom
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:41 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-09 00:25 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-09 00:25:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Review of gconf-editor-2.30.0-1 (3.28 KB, text/plain)
2010-07-09 00:25 EDT, Garrett Holmstrom
no flags Details

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:41:12 EST
Fedora Merge Review: gconf-editor

http://cvs.fedora.redhat.com/viewcvs/devel/gconf-editor/
Initial Owner: rstrode@redhat.com
Comment 1 Matthias Clasen 2007-11-18 13:27:40 EST
rpmlint says:

[mclasen@localhost devel]$ rpmlint i386/gconf-editor-2.20.0-2.fc9.i386.rpm 
gconf-editor.i386: W: non-conffile-in-etc /etc/gconf/schemas/gconf-editor.schemas

which is generally accepted practise for schema files.

Comment 2 Garrett Holmstrom 2010-07-09 00:25:08 EDT
Everything checks out as far as I can tell.  While it isn't mandatory, you might want to query upstream about including the text of the GFDL in their source tarball (COPYING-DOCS) so it can go in the package.  Consider also using %global over %define.

A full review is attached.
Comment 3 Garrett Holmstrom 2010-07-09 00:25:41 EDT
Created attachment 430532 [details]
Review of gconf-editor-2.30.0-1

Note You need to log in before you can comment on or make changes to this bug.