should gdm require "redhat-menus"?

I'm installing XFCE and gdm to a minimal installed system. Yum cannot find
dependency for "/usr/share/desktop-menu-patches/gnome-gdmsetup.desktop", so I
have to specify "redhat-menus" on yum cmdline.

A minor ownership/permission issue is described in bug #487228:

After the first execution of gdm "rpm -V gdm" reports the following changes:

.M....G.    /var/log/gdm
.M......    /var/run/gdm

This should block the merge review.

- %global over %define
  https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- comments to the patches would be good:
  https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

Some other items, I just found:

- DOES NOT BUILD IN KOJI: see below



- macros in %changelog, %pre in line 2098 and %doc in line 2259
  please use %%pre and %%doc instead

- Prereq: /usr/sbin/useradd is deprecated:
  please use Requires: instead

- 122 Obsoletes: fast-user-switch-applet
  123 Provides:  fast-user-switch-applet = %{epoch}:%{version}-%{release}

  Should that not be:
  Obsoletes: fast-user-switch-applet < %{epoch}:%{version}-%{release}
  ?



- DOES NOT BUILD IN KOJI:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1792744

  CC     gdm-product-display.o
  CC     gdm-manager.o
  CC     gdm-slave-proxy.o
sed -e 's,[@]sbindir[@],/usr/sbin,g' <./gdm.in >gdm
  CCLD   gdm-simple-slave
gdm-manager.c:36:1: warning: "DBUS_API_SUBJECT_TO_CHANGE" redefined
<command-line>: warning: this is the location of the previous definition
gdm-manager.c: In function 'gdm_manager_set_xdmcp_enabled':
gdm-manager.c:299: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory'
gdm-manager.c:301: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory'
gdm-manager.c:305: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory'
gdm-manager.c:308: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory'
gdm-manager.c:309: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory'
make[3]: *** [gdm-manager.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1/daemon'
make[2]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1/daemon'
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.laAClY (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.laAClY (%build)

Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:

  https://fedorahosted.org/fesco/ticket/1269

If you don't know what merge reviews are about, please see:

  https://fedoraproject.org/wiki/Merge_Reviews

How to handle this bug is left to the discretion of the package maintainer.

This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.