Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec?ref_type=heads SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5915062651/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm?inline=false Description: mk-configure is a build system, written in and for bmake (portable version of NetBSD make) and UNIX tools (shell, awk etc.). Fedora Account System Username: carlosrodrifernandez Notes for Context: This package is a new requirement to build libmaa (a dependency of dictd), and will be a new requirement to build dictd. The libmaa package is also being separated into its own package instead of being pulled during the dictd package build, and statically compiled as it was before. The libmaa review is in another issue. Libmaa depends on this package to build.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6886523 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/srpm-builds/06886523/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec?ref_type=heads SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5915062651/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm?inline=false
[fedora-review-service-build]
COPR Build: https://copr.fedorainfracloud.org/coprs/carlosrodrifernandez/mk-configure/build/6890150/
Let's make this review blocking the libmaa review then. I used to maintain bmake so it's interesting to see it be used for other things - taking this review
Currently fails with this when running fedora-review: checking for prototype char* strstr(const char*, const char*, int lalala) ( string.h )... no checking for prototype int absent_function(int lalala) ( string.h )... no 14c14 < 1 --- > 0 FAILED *** Error code 1 Stop. bmake[2]: stopped in /builddir/build/BUILD/mk-configure-0.38.3/tests/configure_test *** Error code 1 Stop. bmake[1]: stopped in /builddir/build/BUILD/mk-configure-0.38.3 *** Error code 1 Stop.
Thank you Michel for taking this. I'm looking into the build error, which I was able to reproduce as well.
New version with the fix: Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5964508776/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/carlosrodrifernandez/mk-configure/build/6916639/
Copr build: https://copr.fedorainfracloud.org/coprs/build/6916644 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06916644-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The C files in features and examples are not "development" artifacts, but are part of the package, for documentation, and functionality. The COPYING file is from the examples. The tool LICENSE is in doc/ and has been marked as %license already. Unless I'm missing something, both issues are false positives.
Minor patch cleanup Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5969420586/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Created attachment 2009265 [details] The .spec file difference from Copr build 6916644 to 6921902
Copr build: https://copr.fedorainfracloud.org/coprs/build/6921902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06921902-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file COPYING is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Carlos Rodriguez-Fernandez from comment #11) > The C files in features and examples are not "development" artifacts, but > are part of the package, for documentation, and functionality. > The COPYING file is from the examples. The tool LICENSE is in doc/ and has > been marked as %license already. > Unless I'm missing something, both issues are false positives. can you make a doc / docs / examples subpackage, put the examples there, and then mark the COPYING file in the examples as the license for that subpackage? the warning about header files in features is indeed a false positive, rpmlint gets confused by this kind of package.
The project license is in `doc/` itself. Separating that folder into its own package would remove that file from the core package. What would be the best way to handle that? Just duplicate it? The `examples/` folder contains many examples, and some have COPYING and some don't. There are a total of two COPYINGs file right now, but that could grow with the project. How should I handle also this situation best? Just mark them all with "%license"?
(In reply to Carlos Rodriguez-Fernandez from comment #16) > The project license is in `doc/` itself. Separating that folder into its own > package would remove that file from the core package. What would be the best > way to handle that? Just duplicate it? > probably just split out examples then, and not doc. So your project license is still in the main package > The `examples/` folder contains many examples, and some have COPYING and > some don't. There are a total of two COPYINGs file right now, but that could > grow with the project. How should I handle also this situation best? Just > mark them all with "%license"? yeah, just mark all of them. FWIW the two licenses right now are... exactly identical? Now, what should the license declaration be for the entire examples subpackage - the two examples with COPYING are clearly BSD-2-Clause, the rest looks like trivial programs. from looking at doc/LICENSE I suppose once examples is a subpackage, the ISC license would move from the main package to the subpackage (it only applies to examples/hello_strlcpy/strlcpy.c) ... so main package would be BSD-2-Clause AND BSD-4-Clause -- *not* OR from LICENSE: "Different parts of mk-configure have different copyright holders. All used licences are listed here." examples subpackage would be BSD-2-Clause AND ISC since the examples are installed inside the doc folder of mk-configure, make the subpackage require the main mk-configure if you give %license the absolute path rather than a relative path, it will not move the file - you want to do this for the examples, since they apply to specific example projects %license %{_datadir}/mk-configure/examples/autoconf/proj/COPYING %license %{_datadir}/mk-configure/examples/autotools/proj/COPYING
Thank you Michel for all the feedback. I'll be working on it. I have a question regarding ISC, I found it also inside a few files in the features/ folder. ./features/reallocarray/mkc_reallocarray.c ./features/strlcat/mkc_strlcat.c ./features/strlcpy/mkc_strlcpy.c I should leave it then in the main package as well, right?
New version with feedback implemented Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5972255991/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Created attachment 2009365 [details] The .spec file difference from Copr build 6921902 to 6923699
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923699 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06923699-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file COPYRIGHT is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
New version fixing the COPYRIGHT public domain, and ignoring false positive spelling errors Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5972782915/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Fix incorrect SPDX code Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5972787316/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6924004 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06924004-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2009369 [details] The .spec file difference from Copr build 6924004 to 6924006
Copr build: https://copr.fedorainfracloud.org/coprs/build/6924006 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06924006-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fix missing version specification in the Requires in the doc subpackage. Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5973679324/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Created attachment 2009528 [details] The .spec file difference from Copr build 6924006 to 6926727
Copr build: https://copr.fedorainfracloud.org/coprs/build/6926727 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06926727-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Only a few more things, I think (see the items marked [!]) - is it possible to get a license breakdown of which files are BSD-4-Clause, ISC, and CC0-1.0? If not, just put a comment to refer to LICENSE which is the upstream's file describing the licensing of the different parts of the project - need to depend on either rpm or redhat-rpm-config for directory ownership - using %define instead of %global; see if this still works if you use the latter. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. => false positive ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/rpm/macros.d, /usr/lib/rpm => either Requires: rpm, or if you rely on definitions from other RPM macros, Requires: redhat-rpm-config [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 104022 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define env unset MAKEFLAGS export USE_NM=%{_bindir}/nm export USE_INSTALL=%{_bindir}/install export USE_AWK=%{_bindir}/awk export USE_ID=%{_bindir}/id export USE_CC_COMPILERS='gcc clang' export USE_CXX_COMPILERS='g++ clang' export PREFIX=%{_prefix} export SYSCONFDIR=%{_sysconfdir} export MANDIR=%{_mandir} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: mk-configure-0.38.3-1.fc40.noarch.rpm mk-configure-doc-0.38.3-1.fc40.noarch.rpm mk-configure-0.38.3-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpsa0gylqt')] checks: 31, packages: 3 mk-configure.noarch: W: only-non-binary-in-usr-lib mk-configure.noarch: W: files-duplicate /usr/share/mk-configure/builtins/easy.cc /usr/share/mk-configure/builtins/easy.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/autotools/proj/AUTHORS /usr/share/doc/mk-configure/examples/autoconf/proj/AUTHORS mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/autotools/proj/COPYING /usr/share/doc/mk-configure/examples/autoconf/proj/COPYING mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/autotools/proj/ChangeLog /usr/share/doc/mk-configure/examples/autoconf/proj/ChangeLog mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/autotools/proj/NEWS /usr/share/doc/mk-configure/examples/autoconf/proj/NEWS mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/vis/test.mk /usr/share/doc/mk-configure/examples/bswap/test.mk:/usr/share/doc/mk-configure/examples/efun/test.mk:/usr/share/doc/mk-configure/examples/reallocarray/test.mk:/usr/share/doc/mk-configure/examples/strsep/test.mk mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/requirements/hello_world.c /usr/share/doc/mk-configure/examples/check_compiler_opts/hello_world.c:/usr/share/doc/mk-configure/examples/hello_world/hello_world.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/hello_lua2/bar.lua /usr/share/doc/mk-configure/examples/hello_lua/bar.lua mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/hello_lua3/socket_baz.c /usr/share/doc/mk-configure/examples/hello_lua/baz.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/hello_lua2/foo.lua /usr/share/doc/mk-configure/examples/hello_lua/foo.lua mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/plugins2/Makefile /usr/share/doc/mk-configure/examples/plugins/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/plugins2/plugin1/Makefile /usr/share/doc/mk-configure/examples/plugins/plugin1/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/plugins2/plugin2/Makefile /usr/share/doc/mk-configure/examples/plugins/plugin2/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/strlcpy2/missing/getline.c /usr/share/doc/mk-configure/examples/strlcpy/getline.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/strlcpy2/hello.c /usr/share/doc/mk-configure/examples/strlcpy/hello.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/strlcpy3/input.in /usr/share/doc/mk-configure/examples/strlcpy/input.in:/usr/share/doc/mk-configure/examples/strlcpy2/input.in mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/strlcpy2/missing/strlcpy.c /usr/share/doc/mk-configure/examples/strlcpy/strlcpy.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/bar/Makefile /usr/share/doc/mk-configure/examples/tools/libs/bar/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.c /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/foo/Makefile /usr/share/doc/mk-configure/examples/tools/libs/foo/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.c /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/qux/Makefile /usr/share/doc/mk-configure/examples/tools/libs/qux/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/qux/qux.c /usr/share/doc/mk-configure/examples/tools/libs/qux/qux.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/libs/qux/qux.h.in /usr/share/doc/mk-configure/examples/tools/libs/qux/qux.h.in mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog1/Makefile /usr/share/doc/mk-configure/examples/tools/tools/prog1/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog1/prog1.c /usr/share/doc/mk-configure/examples/tools/tools/prog1/prog1.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog2/prog2.c /usr/share/doc/mk-configure/examples/tools/tools/prog2/prog2.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog3/prog3.c /usr/share/doc/mk-configure/examples/tools/tools/prog3/prog3.c mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog4/Makefile /usr/share/doc/mk-configure/examples/tools/tools/prog4/Makefile mk-configure-doc.noarch: W: files-duplicate /usr/share/doc/mk-configure/examples/tools2/tools/prog4/prog4.c /usr/share/doc/mk-configure/examples/tools/tools/prog4/prog4.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/builtins/easy.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/_mkcfake.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/dprintf/mkc_dprintf.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/efun/mkc_efun.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/err/mkc_err.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/errc/mkc_errc.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/errc/mkc_verrc.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/fgetln/mkc_fgetln.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/fparseln/mkc_fparseln.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/getdelim/mkc_getdelim.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/getline/mkc_getline.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/humanize_number/mkc_humanize_number.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_aligned.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_always_inline.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_const.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_noreturn.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_printflike.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/macro/mkc_attribute_pure.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_LIST.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_RB.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_SLIST.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_arc4random.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_bswap.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_dprintf.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_efun.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_err.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_errc.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_externc.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_fgetln.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_fparseln.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_fts.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_getdelim.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_getline.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_libdl.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_libm.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_macro.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_progname.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_shquote.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strlcat.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strndup.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strsep.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strtoi.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_strtou.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_vis.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/mkc_warn.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/posix_getopt/mkc_posix_getopt.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/progname/mkc_progname.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/pwdgrp/mkc_pwdgrp.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/raise_default_signal/mkc_raise_default_signal.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/reallocarr/mkc_reallocarr.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/reallocarray/mkc_reallocarray.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/shquote/mkc_shquote.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strlcat/mkc_strlcat.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strlcpy/mkc_strlcpy.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strndup/mkc_strndup.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strsep/mkc_strsep.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strto/mkc_strtoi.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/strto/mkc_strtou.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/vis/mkc_unvis.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/vis/mkc_vis.c mk-configure.noarch: W: devel-file-in-non-devel-package /usr/share/mk-configure/features/warn/mkc_warn.c 3 packages and 0 specfiles checked; 0 errors, 109 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mk-configure-doc". (none): E: there is no installed rpm "mk-configure". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/cheusov/mk-configure/archive/refs/tags/0.38.3/mk-configure-0.38.3.tar.gz : CHECKSUM(SHA256) this package : 2dd844694aad36b7900824c8c2e31345ad0b8dcbf366a9086f6b981714eaa8b9 CHECKSUM(SHA256) upstream package : 2dd844694aad36b7900824c8c2e31345ad0b8dcbf366a9086f6b981714eaa8b9 Requires -------- mk-configure (rpmlib, GLIBC filtered): /usr/bin/awk /usr/bin/sh bmake imake mk-configure-doc (rpmlib, GLIBC filtered): mk-configure Provides -------- mk-configure: mk-configure rpm_macro(mkcmake) mk-configure-doc: mk-configure-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mk-configure --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, R, SugarActivity, C/C++, PHP, Perl, Ocaml, Java, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Fixes use of %define, licenses and directory ownership issue. Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5985681640/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Michel, thank you for all the feedback. Regarding the license breakdown, I'm not sure if what I did is what I'm supposed to. Here is the diff: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/commit/bdd6742a58dd14cfe4647572ae28369a901a0e00 I'm also looking into the documentation to see if the breakdown is done differently but not much luck.
Created attachment 2009817 [details] The .spec file difference from Copr build 6926727 to 6941971
Copr build: https://copr.fedorainfracloud.org/coprs/build/6941971 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06941971-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Clarified the rest of licenses in the examples doc package Spec URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/raw/main/mk-configure.spec SRPM URL: https://gitlab.com/carlosrodfern/rpms-mk-configure/-/jobs/5992496572/artifacts/raw/mk-configure-0.38.3-1.fc40.src.rpm
Created attachment 2009924 [details] The .spec file difference from Copr build 6941971 to 6943421
Copr build: https://copr.fedorainfracloud.org/coprs/build/6943421 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257985-mk-configure/fedora-rawhide-x86_64/06943421-mk-configure/fedora-review/review.txt Found issues: - mk-configure : /usr/share/mk-configure/features/mkc_CIRCLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_LIST.h mk-configure : /usr/share/mk-configure/features/mkc_RB.h mk-configure : /usr/share/mk-configure/features/mkc_SIMPLEQ.h mk-configure : /usr/share/mk-configure/features/mkc_SLIST.h mk-configure : /usr/share/mk-configure/features/mkc_SPLAY.h mk-configure : /usr/share/mk-configure/features/mkc_STAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_TAILQ.h mk-configure : /usr/share/mk-configure/features/mkc_arc4random.h mk-configure : /usr/share/mk-configure/features/mkc_bswap.h mk-configure : /usr/share/mk-configure/features/mkc_dprintf.h mk-configure : /usr/share/mk-configure/features/mkc_efun.h mk-configure : /usr/share/mk-configure/features/mkc_err.h mk-configure : /usr/share/mk-configure/features/mkc_errc.h mk-configure : /usr/share/mk-configure/features/mkc_externc.h mk-configure : /usr/share/mk-configure/features/mkc_fgetln.h mk-configure : /usr/share/mk-configure/features/mkc_fparseln.h mk-configure : /usr/share/mk-configure/features/mkc_fts.h mk-configure : /usr/share/mk-configure/features/mkc_getdelim.h mk-configure : /usr/share/mk-configure/features/mkc_getline.h mk-configure : /usr/share/mk-configure/features/mkc_humanize_number.h mk-configure : /usr/share/mk-configure/features/mkc_libdl.h mk-configure : /usr/share/mk-configure/features/mkc_libm.h mk-configure : /usr/share/mk-configure/features/mkc_macro.h mk-configure : /usr/share/mk-configure/features/mkc_posix_getopt.h mk-configure : /usr/share/mk-configure/features/mkc_progname.h mk-configure : /usr/share/mk-configure/features/mkc_pwdgrp.h mk-configure : /usr/share/mk-configure/features/mkc_raise_default_signal.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarr.h mk-configure : /usr/share/mk-configure/features/mkc_reallocarray.h mk-configure : /usr/share/mk-configure/features/mkc_shquote.h mk-configure : /usr/share/mk-configure/features/mkc_strlcat.h mk-configure : /usr/share/mk-configure/features/mkc_strlcpy.h mk-configure : /usr/share/mk-configure/features/mkc_strndup.h mk-configure : /usr/share/mk-configure/features/mkc_strsep.h mk-configure : /usr/share/mk-configure/features/mkc_strtoi.h mk-configure : /usr/share/mk-configure/features/mkc_strtou.h mk-configure : /usr/share/mk-configure/features/mkc_vis.h mk-configure : /usr/share/mk-configure/features/mkc_warn.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_queue.h mk-configure : /usr/share/mk-configure/features/netbsd_sys_tree.h mk-configure : /usr/share/mk-configure/features/strto/mkc__strtoi.h mk-configure-doc : /usr/share/doc/mk-configure/examples/c99/inline_func.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/five.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxx/seven.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/hello_msg.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib/include/impl/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/cxxlib/cxxlib2/include/hello_msg2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libbaz/include/baz.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfoo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/libdeps/libs/libfooqux/fooqux.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello1/hello1.h mk-configure-doc : /usr/share/doc/mk-configure/examples/subprojects/libhello2/include/hello2.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools/libs/foo/foo.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/bar/bar.h mk-configure-doc : /usr/share/doc/mk-configure/examples/tools2/libs/foo/foo.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Michel, Any other feedback/update on the package? Thank you.
Apologies, this slipped through. Everything looks fine, APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/mk-configure