Spec URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/06887721-python-freeqdsk/python-freeqdsk.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/06887721-python-freeqdsk/python-freeqdsk-0.4.0-1.fc40.src.rpm Description: Read and write G-EQDSK, A-EQDSK, and P-EQDSK file formats, which are used to describe the tokamak fusion devices. Fedora Account System Username: davidsch
Copr build: https://copr.fedorainfracloud.org/coprs/build/6887731 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258036-python-freeqdsk/fedora-rawhide-x86_64/06887731-python-freeqdsk/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/davidsch/testing/build/6887721/ Build log: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/06887721-python-freeqdsk/builder-live.log.gz Review template: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/06887721-python-freeqdsk/fedora-review/review.txt
Updated to latest version + Fixed FTBFS Spec URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/08434969-python-freeqdsk/python-freeqdsk.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/08434969-python-freeqdsk/python-freeqdsk-0.5.0-1.fc42.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8434971 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258036-python-freeqdsk/fedora-rawhide-x86_64/08434971-python-freeqdsk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://davidsch.fedorapeople.org/python-freeqdsk.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/08434969-python-freeqdsk/python-freeqdsk-0.5.0-1.fc42.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8444290 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258036-python-freeqdsk/fedora-rawhide-x86_64/08444290-python-freeqdsk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
*** Bug 2334205 has been marked as a duplicate of this bug. ***
Overall the packaging is correct. Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Please, do not use hash tag in Patch line but https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25.patch - [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) - You may even use "%pyproject_check_import" in Check section (see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_check_import) before pytest ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 31 files have unknown license. Detailed output of licensecheck in /home/sagitter/2258036-python- freeqdsk/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1748 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-freeqdsk-0.5.0-1.fc42.noarch.rpm python-freeqdsk-0.5.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpd1zqipnx')] checks: 32, packages: 2 python-freeqdsk.src: E: spelling-error ('tokamak', '%description -l en_US tokamak -> toolmaker') python3-freeqdsk.noarch: E: spelling-error ('tokamak', '%description -l en_US tokamak -> toolmaker') 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 9 filtered, 2 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-freeqdsk.noarch: E: spelling-error ('tokamak', '%description -l en_US tokamak -> toolmaker') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 5 filtered, 1 badness; has taken 0.2 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/freeqdsk/freeqdsk-0.5.0.tar.gz : CHECKSUM(SHA256) this package : a919248cd5a48ed76511f7bb175feb446380ffbd51f57630a277b35a37a73962 CHECKSUM(SHA256) upstream package : a919248cd5a48ed76511f7bb175feb446380ffbd51f57630a277b35a37a73962 Requires -------- python3-freeqdsk (rpmlib, GLIBC filtered): (python3.13dist(fortranformat) >= 2 with python3.13dist(fortranformat) < 3) python(abi) python3.13dist(numpy) Provides -------- python3-freeqdsk: python-freeqdsk python3-freeqdsk python3.13-freeqdsk python3.13dist(freeqdsk) python3dist(freeqdsk) Diff spec file in url and in SRPM --------------------------------- --- /home/sagitter/2258036-python-freeqdsk/srpm/python-freeqdsk.spec 2024-12-26 19:27:43.086017088 +0100 +++ /home/sagitter/2258036-python-freeqdsk/srpm-unpacked/python-freeqdsk.spec 2024-12-21 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: python-freeqdsk Version: 0.5.0 @@ -52,3 +62,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sat Dec 21 2024 John Doe <packager> - 0.5.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 --mock-option=--no-clean -b 2258036 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Java, PHP, Perl, Haskell, R, C/C++, SugarActivity, fonts, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Antonio T. sagitter from comment #8) > Overall the packaging is correct. > Approved. > Thanks! > Issues: > ======= > - Dist tag is present. I assumed this is a false positive? > - Please, do not use hash tag in Patch line but > https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25. > patch I find the name 25.patch not very helpful. Maybe gh-pr-25.patch? Or why would you prefer 25.patch? > - [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) > > - You may even use "%pyproject_check_import" in Check section (see > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #pyproject_check_import) before pytest Thanks, done!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-freeqdsk
FEDORA-2024-f881a5780c (python-freeqdsk-0.5.0-1.fc42 and python-zoidberg-0.2.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f881a5780c
FEDORA-2024-f881a5780c (python-freeqdsk-0.5.0-1.fc42 and python-zoidberg-0.2.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
(In reply to david08741 from comment #9) > (In reply to Antonio T. sagitter from comment #8) > > Overall the packaging is correct. > > Approved. > > > Thanks! > > > > Issues: > > ======= > > - Dist tag is present. > I assumed this is a false positive? A conflict, maybe, between "%autorelease" vs "%{autorelease}" > > > - Please, do not use hash tag in Patch line but > > https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25. > > patch > > I find the name 25.patch not very helpful. Maybe gh-pr-25.patch? Or why > would you prefer 25.patch? https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25.patch and a comment containing the link to the "pull request"