Bug 2258183 - Review Request: rust-uu_shuf - shuf ~ (uutils) display random permutations of input lines
Summary: Review Request: rust-uu_shuf - shuf ~ (uutils) display random permutations of...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/uu_shuf
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-13 03:04 UTC by Michel Lind
Modified: 2024-01-31 02:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-26 03:27:20 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6894924 to 6923989 (491 bytes, patch)
2024-01-20 04:27 UTC, Fedora Review Service
no flags Details | Diff

Description Michel Lind 2024-01-13 03:04:36 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_shuf.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_shuf-0.0.23-1.fc38.src.rpm

Description:
shuf ~ (uutils) display random permutations of input lines.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-14 01:05:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6894924
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258183-rust-uu_shuf/fedora-rawhide-x86_64/06894924-rust-uu_shuf/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-18 21:48:02 UTC
The file "src/rand_read_adapter.rs" is licensed "MIT OR Apache-2.0" - it will not change the license of the binary file, but it needs to be documented for the source package, maybe something like

# * uu_shuf except src/rand_read_adapter.rs: MIT
# * src/rand_read_adapter.rs: MIT OR Apache-2.0
License:     MIT AND (MIT OR Apache-2.0)

Comment 3 Michel Lind 2024-01-20 04:18:15 UTC
Updated, thanks

[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-01-20 04:27:15 UTC
Created attachment 2009368 [details]
The .spec file difference from Copr build 6894924 to 6923989

Comment 5 Fedora Review Service 2024-01-20 04:27:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6923989
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258183-rust-uu_shuf/fedora-rawhide-x86_64/06923989-rust-uu_shuf/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2024-01-25 22:59:01 UTC
Thank you for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.0.23 vs. v0.0.23)
~ license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

I'm not sure if we need to include a copy of the Apache-2.0 license text, but assuming you opt to distribute the "MIT OR Apache-2.0" licensed file as "just MIT" it should be fine. Either way it will not have an effect on the License tag.

Comment 7 Fedora Admin user for bugzilla script actions 2024-01-26 03:03:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_shuf

Comment 8 Fedora Update System 2024-01-26 03:25:24 UTC
FEDORA-2024-77fab050f2 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-77fab050f2

Comment 9 Fedora Update System 2024-01-26 03:27:20 UTC
FEDORA-2024-77fab050f2 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-01-26 22:46:02 UTC
FEDORA-2024-0ef58d2acd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0ef58d2acd

Comment 11 Fedora Update System 2024-01-26 22:46:03 UTC
FEDORA-2024-029c153ccd has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-029c153ccd

Comment 12 Fedora Update System 2024-01-27 02:35:07 UTC
FEDORA-2024-029c153ccd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-029c153ccd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-029c153ccd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-01-27 03:05:51 UTC
FEDORA-2024-0ef58d2acd has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0ef58d2acd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0ef58d2acd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-01-31 01:42:22 UTC
FEDORA-2024-0ef58d2acd has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-01-31 02:04:27 UTC
FEDORA-2024-029c153ccd has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.