Spec URL: https://salimma.fedorapeople.org/specs/rust-rlimit.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-rlimit-0.10.1-1.fc38.src.rpm Description: Resource limits. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6894960 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258271-rust-rlimit/fedora-rawhide-x86_64/06894960-rust-rlimit/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package is APPROVED, with one recommended change related to patch upstream status. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is almost exactly as generated by rust2rpm, simplifying the review. I noted the following difference: --- ./rust-rlimit.spec 2024-01-16 11:17:46.072293254 -0500 +++ ../srpm-unpacked/rust-rlimit.spec 2024-01-12 19:00:00.000000000 -0500 @@ -51,6 +51,8 @@ %prep %autosetup -n %{crate}-%{version} -p1 +# fix permission, otherwise mangle-shebangs will try and parse this +chmod -x src/bindings.rs %cargo_prep %generate_buildrequires This change makes sense, but it would be better fixed upstream. I opened a PR: Remove spurious executable bit from a Rust source https://github.com/Nugine/rlimit/pull/59 Please consider linking that PR, and perhaps even applying it as a patch (https://github.com/Nugine/rlimit/pull/59.patch) so that you notice when the unwanted executable bit goes away in a future release. This doesn’t block the review. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/rlimit-0.10.1/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is due to rust2rpm listing the entire %{crate_instdir}/ and then separately listing some of its contents as %doc. The duplication appears to be harmless; if it is a problem, then it should be fixed in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 30 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2258271-rust-rlimit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. $ rpm -qL -p results/rust-rlimit-devel-0.10.1-1.fc40.noarch.rpm /usr/share/cargo/registry/rlimit-0.10.1/LICENSE [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- rlimit-devel , rust-rlimit+default-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=111837814 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-rlimit-devel-0.10.1-1.fc40.noarch.rpm rust-rlimit+default-devel-0.10.1-1.fc40.noarch.rpm rust-rlimit-0.10.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3syh2pnx')] checks: 31, packages: 3 rust-rlimit+default-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-rlimit+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/rlimit/0.10.1/download#/rlimit-0.10.1.crate : CHECKSUM(SHA256) this package : 3560f70f30a0f16d11d01ed078a07740fe6b489667abc7c7b029155d9f21c3d8 CHECKSUM(SHA256) upstream package : 3560f70f30a0f16d11d01ed078a07740fe6b489667abc7c7b029155d9f21c3d8 Requires -------- rust-rlimit-devel (rpmlib, GLIBC filtered): (crate(libc/default) >= 0.2.147 with crate(libc/default) < 0.3.0~) /usr/bin/bash cargo rust rust-rlimit+default-devel (rpmlib, GLIBC filtered): cargo crate(rlimit) Provides -------- rust-rlimit-devel: crate(rlimit) rust-rlimit-devel rust-rlimit+default-devel: crate(rlimit/default) rust-rlimit+default-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2258271 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, Python, R, Ocaml, SugarActivity, fonts, PHP, Haskell, Perl, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Ben Beasley from comment #2) > The package is APPROVED, with one recommended change related to patch > upstream status. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > The spec file is almost exactly as generated by rust2rpm, simplifying the > review. > > I noted the following difference: > > --- ./rust-rlimit.spec 2024-01-16 11:17:46.072293254 -0500 > +++ ../srpm-unpacked/rust-rlimit.spec 2024-01-12 19:00:00.000000000 -0500 > @@ -51,6 +51,8 @@ > > %prep > %autosetup -n %{crate}-%{version} -p1 > +# fix permission, otherwise mangle-shebangs will try and parse this > +chmod -x src/bindings.rs > %cargo_prep > > %generate_buildrequires > > This change makes sense, but it would be better fixed upstream. I opened a > PR: > > Remove spurious executable bit from a Rust source > https://github.com/Nugine/rlimit/pull/59 > > Please consider linking that PR, and perhaps even applying it as a patch > (https://github.com/Nugine/rlimit/pull/59.patch) so that you notice when the > unwanted executable bit goes away in a future release. > Thank you!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rlimit
FEDORA-2024-a197530b41 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a197530b41
FEDORA-2024-a197530b41 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e44cd530a4 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e44cd530a4
FEDORA-2024-f9495c880c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f9495c880c
FEDORA-2024-e44cd530a4 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e44cd530a4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e44cd530a4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-f9495c880c has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f9495c880c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f9495c880c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-e44cd530a4 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-f9495c880c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.