Bug 225843 - Merge Review: gnome-vfs2
Merge Review: gnome-vfs2
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:55 EST by Nobody's working on this, feel free to take it
Modified: 2010-10-22 00:36 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-10-22 00:36:09 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
spec cleanup (7.75 KB, patch)
2010-10-18 04:42 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:55:51 EST
Fedora Merge Review: gnome-vfs2

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-vfs2/
Initial Owner: alexl@redhat.com
Comment 1 Ville Skyttä 2007-03-06 16:18:30 EST
What is the license of this package?  License tag says LGPL, upstream tarball
contains both GPL and LGPL license texts, and only the GPL file is included in
binary packages.
Comment 2 Alexander Larsson 2007-03-07 05:11:49 EST
The library is LGPL, and some executables are GPL.
Comment 3 Parag AN(पराग) 2010-10-18 04:42:39 EDT
Created attachment 454040 [details]
spec cleanup

Please commit this git patch that will clean this package for this review or allow to commit.
Comment 4 Tomáš Bžatek 2010-10-18 05:57:15 EDT
Why did you remove all version checks from Requires/BuildRequires? I know we have new versions of everything in rawhide nowadays but still we might want to bump some dependency one day, introducing versioning back.

> @@ -102,12 +85,6 @@ library, and other features.
>  Summary: Libraries and include files for developing GNOME VFS applications
>  Group: Development/Libraries
>  Requires:   %{name} = %{version}-%{release}
> -Requires:   GConf2-devel >= %{gconf2_version}
> -Requires:   hal-devel >= %{hal_version}
> -Requires:   dbus-devel >= %{dbus_version}
> -Requires:   dbus-glib-devel >= %{dbus_glib_version}
> -Requires:   pkgconfig
Why did you remove these explicit devel packages requires? They're there for purpose.

Otherwise all other changes look good. This package is considered dead anyway and will be removed in near or far future. It is maintained only as a dependency for packages that have not been ported to GIO yet.
Comment 5 Parag AN(पराग) 2010-10-18 06:25:50 EDT
1) Removing versioned BR:
=> Yes you are correct. We first used to build dependencies for this package and then this package. If that is the case then why to un-necessarily write versioned BR:?

I think repoquery is the best option to check which packages need to be bumped as part of any dependent package bump.


2) Removing explicit Requires:
==> Guidelines says https://fedoraproject.org/wiki/PackagingGuidelines#Explicit_Requires

If I have missed any explicit requires, please tell me and will add it back to suggested patch.

For your reference here is modified scratch package build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2540235

And See Requires generated automatically from .pc files at
Processing files: gnome-vfs2-devel-2.24.4-2.fc15.x86_64
Requires: /usr/bin/pkg-config libgnomevfs-2.so.0()(64bit) pkgconfig(gconf-2.0) pkgconfig(gmodule-no-export-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0)

Compared to older version
Processing files: gnome-vfs2-devel-2.24.4-1.fc15.x86_64
Requires: /usr/bin/pkg-config libgnomevfs-2.so.0()(64bit) pkgconfig(gconf-2.0) pkgconfig(gmodule-no-export-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0)


Looks both are equal. When I looked into .pc files I have not found any reference to pull dbus and hal dependencies.


Please correct me if I am wrong.
Comment 6 Parag AN(पराग) 2010-10-20 08:07:45 EDT
I will commit this tomorrow.
Comment 7 Parag AN(पराग) 2010-10-22 00:36:09 EDT
Committed the above patch and built in gnome-vfs2-2.24.4-1.fc15

APPROVED.

Note You need to log in before you can comment on or make changes to this bug.