Bug 225851 - Merge Review: gob2
Merge Review: gob2
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Miroslav Lichvar
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:56 EST by Nobody's working on this, feel free to take it
Modified: 2009-12-03 07:01 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-12-03 07:01:51 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mlichvar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:56:58 EST
Fedora Merge Review: gob2

http://cvs.fedora.redhat.com/viewcvs/devel/gob2/
Initial Owner: harald@redhat.com
Comment 1 Miroslav Lichvar 2009-12-02 12:21:56 EST
Review follows:

OK source files match upstream:
cced6d709df6fad3baf8831f027d62d5  gob2-2.0.16.tar.gz
BAD source contains full URL
- source should point to http://ftp.5z.com/pub/gob/gob2-2.0.16.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
- %makeinstall can be replaced with more correct
   make install DESTDIR=$RPM_BUILD>_ROOT
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license (GPLv2+).
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock.
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
Comment 2 Daniel Novotny 2009-12-03 06:53:21 EST
so the only problem is the "Source:" URL.
fixed in rawhide and F-12
-built F12 release candidate gob2-2.0.16-5.fc12, rawhide gob2-2.0.16-4.fc13
Comment 3 Miroslav Lichvar 2009-12-03 07:01:51 EST
Approved.

Note You need to log in before you can comment on or make changes to this bug.