Fedora Merge Review: gpart http://cvs.fedora.redhat.com/viewcvs/devel/gpart/ Initial Owner: dcantrell
Good: * Source URL is canonical * Group Tag is from the official list * Package builds in Mock. Need to be Fixed: * rpmlint error: W: gpart-debuginfo no-url-tag Need to add URL: http://www.stud.uni-hannover.de/user/76201/gpart/ Minor: * Doesn't use preferred buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Drop the '.' from the summary to quite rpmlint. * Should use path macro. %{_bindir}/gpart
(In reply to comment #1) > Need to be Fixed: > * rpmlint error: > W: gpart-debuginfo no-url-tag > Need to add URL: http://www.stud.uni-hannover.de/user/76201/gpart/ Done. > Minor: > * Doesn't use preferred buildroot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Done. > * Drop the '.' from the summary to quite rpmlint. Done. > * Should use path macro. %{_bindir}/gpart I changed it to use %makeinstall instead. Also noticed the debuginfo package didn't actually contain anything. The src/Makefile was installing the gpart binary stripped, so there was nothing to pack in to debuginfo form. Fixed that.
Is this package review done?
(In reply to comment #3) > Is this package review done? Pretty much. The only thing that should probably still be changed is that in the %file section you should use '%{_bindir}/gpart', instead of '/usr/bin/gpart'. I'll go ahead and approve this.
Made that change. Can the bug be closed now?
Yup. Thanks.