Bug 225867 - Merge Review: gthumb
Merge Review: gthumb
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:59 EST by Nobody's working on this, feel free to take it
Modified: 2010-10-06 00:43 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-10-05 00:30:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
build libgthumb static (493 bytes, patch)
2007-01-31 14:15 EST, Yanko Kaneti
no flags Details | Diff
spec cleanup (2.70 KB, patch)
2010-09-25 05:48 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:59:28 EST
Fedora Merge Review: gthumb

http://cvs.fedora.redhat.com/viewcvs/devel/gthumb/
Initial Owner: besfahbo@redhat.com
Comment 1 Yanko Kaneti 2007-01-31 14:14:15 EST
gthumb-2.9.1-1 packs an unversioned shared library in the system dynamic linker
path without apparent outside users.
%{_libdir}/libgthumb.so

It maybe an upstream development and subject to change, but from a distribution
point of view I think its wise to not include it in the package.
Attaching a patch to built the library static. Not sure if thats the proper way
but it seems to achieve the goal here.
It requires an autoreconf and tweaking the filelist.
Comment 2 Yanko Kaneti 2007-01-31 14:15:29 EST
Created attachment 147040 [details]
build libgthumb static
Comment 3 Behdad Esfahbod 2007-02-01 13:15:21 EST
The right way to do it is:

-libgthumb_LTLIBRARIES = libgthumb.la
+noinst_LTLIBRARIES = libgthumb.la
 libgthumb_la_LDFLAGS = -avoid-version -no-undefined

So you've checked and only one binary uses this?
Comment 4 Yanko Kaneti 2007-02-01 14:48:16 EST
(In reply to comment #3)
> The right way to do it is:
> 
> -libgthumb_LTLIBRARIES = libgthumb.la
> +noinst_LTLIBRARIES = libgthumb.la
>  libgthumb_la_LDFLAGS = -avoid-version -no-undefined

gives me trouble when linking the libjpegtran.so module

> So you've checked and only one binary uses this?

at least none that I can see in core or extras
The only users seem to be the gthumb DSO modules in %(_libdir}/gthumb/modules
Which perhaps points that its advisable to still build the shared lib but leave
it in some private ghtumb link path.
Comment 5 Yanko Kaneti 2007-02-01 15:27:33 EST
-libgthumbdir = $(libdir)
+libgthumbdir = $(libdir)/gthumb

and autoreconf seems to achieve said goal

One more thing

-%configure %{gphoto_flags}
+%configure %{?gphoto_flags}
Comment 6 Behdad Esfahbod 2007-02-01 22:42:30 EST
(In reply to comment #5)
> -libgthumbdir = $(libdir)
> +libgthumbdir = $(libdir)/gthumb
> 
> and autoreconf seems to achieve said goal

But do the modules then find it?
Comment 7 Yanko Kaneti 2007-02-01 23:16:51 EST
(In reply to comment #6)
> (In reply to comment #5)
> > -libgthumbdir = $(libdir)
> > +libgthumbdir = $(libdir)/gthumb
> > 
> > and autoreconf seems to achieve said goal
> 
> But do the modules then find it?

yep. Everything appears to work fine.
also
$  readelf -a /usr/bin/gthumb /usr/lib/gthumb/modules/libjpegtran.so  | grep RPATH
 0x0000000f (RPATH)                      Library rpath: [/usr/lib/gthumb]
 0x0000000f (RPATH)                      Library rpath: [/usr/lib/gthumb]

Comment 8 Parag AN(पराग) 2010-09-25 05:48:04 EDT
Created attachment 449580 [details]
spec cleanup

Please commit this patch to clean this package or allow to commit it.
Comment 9 Parag AN(पराग) 2010-10-05 00:30:29 EDT
Fixed in gthumb-2.11.91-3.fc15


APPROVED.

Note You need to log in before you can comment on or make changes to this bug.