Fedora Merge Review: gthumb http://cvs.fedora.redhat.com/viewcvs/devel/gthumb/ Initial Owner: besfahbo
gthumb-2.9.1-1 packs an unversioned shared library in the system dynamic linker path without apparent outside users. %{_libdir}/libgthumb.so It maybe an upstream development and subject to change, but from a distribution point of view I think its wise to not include it in the package. Attaching a patch to built the library static. Not sure if thats the proper way but it seems to achieve the goal here. It requires an autoreconf and tweaking the filelist.
Created attachment 147040 [details] build libgthumb static
The right way to do it is: -libgthumb_LTLIBRARIES = libgthumb.la +noinst_LTLIBRARIES = libgthumb.la libgthumb_la_LDFLAGS = -avoid-version -no-undefined So you've checked and only one binary uses this?
(In reply to comment #3) > The right way to do it is: > > -libgthumb_LTLIBRARIES = libgthumb.la > +noinst_LTLIBRARIES = libgthumb.la > libgthumb_la_LDFLAGS = -avoid-version -no-undefined gives me trouble when linking the libjpegtran.so module > So you've checked and only one binary uses this? at least none that I can see in core or extras The only users seem to be the gthumb DSO modules in %(_libdir}/gthumb/modules Which perhaps points that its advisable to still build the shared lib but leave it in some private ghtumb link path.
-libgthumbdir = $(libdir) +libgthumbdir = $(libdir)/gthumb and autoreconf seems to achieve said goal One more thing -%configure %{gphoto_flags} +%configure %{?gphoto_flags}
(In reply to comment #5) > -libgthumbdir = $(libdir) > +libgthumbdir = $(libdir)/gthumb > > and autoreconf seems to achieve said goal But do the modules then find it?
(In reply to comment #6) > (In reply to comment #5) > > -libgthumbdir = $(libdir) > > +libgthumbdir = $(libdir)/gthumb > > > > and autoreconf seems to achieve said goal > > But do the modules then find it? yep. Everything appears to work fine. also $ readelf -a /usr/bin/gthumb /usr/lib/gthumb/modules/libjpegtran.so | grep RPATH 0x0000000f (RPATH) Library rpath: [/usr/lib/gthumb] 0x0000000f (RPATH) Library rpath: [/usr/lib/gthumb]
Created attachment 449580 [details] spec cleanup Please commit this patch to clean this package or allow to commit it.
Fixed in gthumb-2.11.91-3.fc15 APPROVED.