Bug 225885 - Merge Review: hexedit
Merge Review: hexedit
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Patrice Dumas
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:03 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-17 15:50 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-01-17 15:50:41 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
pertusus: fedora‑review+

Attachments (Terms of Use)
misc spec file fixes (1.05 KB, patch)
2007-10-25 15:56 EDT, Patrice Dumas
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:03:31 EST
Fedora Merge Review: hexedit

Initial Owner: jnovy@redhat.com
Comment 1 Patrice Dumas 2007-10-25 15:52:13 EDT
The source file timestamp is not kept. This is too late for this
release, but next time it will be better to fetch it with wget -N
or spectool -g to keep the timestamp.

source match upstream
0d2f48610006278cd93359fea9a06d5c  hexedit-1.2.12.src.tgz

rpmlint is silent.
Comment 2 Patrice Dumas 2007-10-25 15:56:45 EDT
Created attachment 237951 [details]
misc spec file fixes

set license to GPLv2+.
Remove unuseful export CFLAGS="$RPM_OPT_FLAGS".
keep man page timestamp.
add %{_smp_mflags}
Comment 3 Jiri Moskovcak 2007-12-17 09:49:10 EST
Branches F-7, F-8 and devel have been fixed.

Comment 4 Patrice Dumas 2007-12-17 10:12:54 EST
It would be nice to also install hexedit-1.2.12.lsm in %doc, 
presumably using a wildcard for the version, since there is 
no readme and it lists the author.

This bug should be assigned to the reviewer formally taking
the review and not to the submitter.
Comment 5 Jiri Moskovcak 2007-12-17 11:21:14 EST
I added hexedit-%{version}.lsm to %doc.

Comment 6 Patrice Dumas 2007-12-17 11:26:47 EST
Looks good now, approved.
Comment 7 Patrice Dumas 2008-01-17 15:50:41 EST

Note You need to log in before you can comment on or make changes to this bug.