Fedora Merge Review: hicolor-icon-theme http://cvs.fedora.redhat.com/viewcvs/devel/hicolor-icon-theme/ Initial Owner: davidz
After some fixes, rpmlint is silent now
This package has been around forever. But let's make it match the guidelines. Here are my notes: * The URL in the SPEC file needs fixed. The new URL is http://icon-theme.freedesktop.org/wiki/HicolorTheme * It would be better if the file Changelog is included in the RPM. * Disttag is missing. Is there a particular reason? * The two exit 0 lines seem unnecessary. Well, that's pretty much it :)
ping?
I've updated the URL, removed the redundant exit 0s and included ChangeLog. dist tag seems pointless for a package that gets build only every few years. I normally don't include ChangeLogs, since a) they tend to be large and b) the user-relevant information is supposed to be in NEWS. In this case, there is no NEWS and ChangeLog is tiny, so you got it.
Thanks. I don't have anything against changelogs. Actually, as a technical user, I like them; they are one of the first things I go and check when I update my Fedora. I'm pretty sure there are some people out there who don't mind large changelogs. Well that's my opinion. ---------------------------------------------------------- This Merge Review (hicolor-icon-theme) is APPROVED by oget ---------------------------------------------------------- Closing the bug now...