Bug 225887 - Merge Review: hicolor-icon-theme
Merge Review: hicolor-icon-theme
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Orcan Ogetbil
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:03 EST by Nobody's working on this, feel free to take it
Modified: 2009-01-23 21:37 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-23 21:37:49 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
oget.fedora: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:03:55 EST
Fedora Merge Review: hicolor-icon-theme

http://cvs.fedora.redhat.com/viewcvs/devel/hicolor-icon-theme/
Initial Owner: davidz@redhat.com
Comment 1 Matthias Clasen 2007-11-18 01:27:51 EST
After some fixes, rpmlint is silent now
Comment 2 Orcan Ogetbil 2008-10-27 00:27:40 EDT
This package has been around forever. But let's make it match the guidelines. Here are my notes:

* The URL in the SPEC file needs fixed. The new URL is
http://icon-theme.freedesktop.org/wiki/HicolorTheme

* It would be better if the file Changelog is included in the RPM.

* Disttag is missing. Is there a particular reason?

* The two
   exit 0
lines seem unnecessary.

Well, that's pretty much it :)
Comment 3 Orcan Ogetbil 2008-12-10 14:05:24 EST
ping?
Comment 4 Matthias Clasen 2009-01-23 21:12:41 EST
I've updated the URL, removed the redundant exit 0s and included ChangeLog.
dist tag seems pointless for a package that gets build only every few years.
I normally don't include ChangeLogs, since a) they tend to be large and b) the
user-relevant information is supposed to be in NEWS. In this case, there is no NEWS and ChangeLog is tiny, so you got it.
Comment 5 Orcan Ogetbil 2009-01-23 21:37:49 EST
Thanks. I don't have anything against changelogs. Actually, as a technical user, I like them; they are one of the first things I go and check when I update my Fedora. I'm pretty sure there are some people out there who don't mind large changelogs. Well that's my opinion.

----------------------------------------------------------
This Merge Review (hicolor-icon-theme) is APPROVED by oget
----------------------------------------------------------

Closing the bug now...

Note You need to log in before you can comment on or make changes to this bug.