Bug 2258882 - Review Request: rust-totp-lite - Simple, correct TOTP library
Summary: Review Request: rust-totp-lite - Simple, correct TOTP library
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/totp-lite
Whiteboard:
Depends On: 2256403
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-17 21:24 UTC by Michel Lind
Modified: 2024-07-04 22:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-04 22:22:58 UTC
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Michel Lind 2024-01-17 21:24:34 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-totp-lite.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-totp-lite-2.0.1-1.fc38.src.rpm

Description:
A simple, correct TOTP library.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-17 21:28:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6913632
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258882-rust-totp-lite/fedora-rawhide-x86_64/06913632-rust-totp-lite/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-25 23:29:29 UTC
Would it be possible to port this from koibumi-base32 to a different crate?
The base32 or data-encoding crates come to mind as possible alternatives.

koibumi-base32 is GPL licensed which is quite unusual for a Rust project.
According to the README it also has a bit unusual behaviour (all lowercase, no padding support) when compared to "standard" base64 which might be unexpected.

Comment 3 Michel Lind 2024-07-04 22:22:58 UTC
Turns out this is not actually needed as the package was not retired for long enough -- I filed for unretirement the same day I filed this... not sure exactly which one is first, and forgot to close this one. I suspect I did all the builds for missing packages locally, filed review requests for them, and then noticed it was actually recently retired.

Sorry for the noise! This should be a good todo - get upstream to switch to base32 (which rbw which uses totp-lite actually needs anyway). It's only a test dependency so should be easy to switch without affecting anything else.

Comment 4 Michel Lind 2024-07-04 22:23:25 UTC
For completeness - https://pagure.io/releng/issue/11893


Note You need to log in before you can comment on or make changes to this bug.