Spec URL: https://yselkowitz.fedorapeople.org/libgedit-amtk.spec SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-amtk-5.8.0-1.fc40.src.rpm Description: Amtk is the acronym for “Actions, Menus and Toolbars Kit”. It is a basic GtkUIManager replacement based on GAction. It is suitable for both a traditional UI or a modern UI with a GtkHeaderBar. (This is a rename of the current amtk package to match upstream, needed for Gedit 46.) Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/6914052 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258912-libgedit-amtk/fedora-rawhide-x86_64/06914052-libgedit-amtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://yselkowitz.fedorapeople.org/libgedit-amtk.spec SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-amtk-5.9.0-1.fc42.src.rpm
Created attachment 2063615 [details] The .spec file difference from Copr build 6914052 to 8439941
Copr build: https://copr.fedorainfracloud.org/coprs/build/8439941 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258912-libgedit-amtk/fedora-rawhide-x86_64/08439941-libgedit-amtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://yselkowitz.fedorapeople.org/libgedit-amtk.spec SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-amtk-5.9.0-1.fc43.src.rpm
Created attachment 2082000 [details] The .spec file difference from Copr build 8439941 to 8820155
Copr build: https://copr.fedorainfracloud.org/coprs/build/8820155 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258912-libgedit-amtk/fedora-rawhide-x86_64/08820155-libgedit-amtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
1. Conflicts: amtk < %{version}-%{release} Why that instead of Provides:+Obsoletes: pair? 2. Conflicts: amtk-devel < 5.9.0-1.fc43 Obsoletes: amtk-devel < 5.9.0-1.fc43 Why Conflicts: ? Also, upstream docs say that libgedit-amtk 5.8.0 was the first under that name, so I guess: Obsoletes: amtk-devel < 5.8.0 should suffice? 3. tests are present but not executed, is there a problem with running them in %check? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3". 53 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/libgedit- amtk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7434 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libgedit-amtk-5.9.0-1.fc43.x86_64.rpm libgedit-amtk-devel-5.9.0-1.fc43.x86_64.rpm libgedit-amtk-5.9.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe0qndgml')] checks: 32, packages: 3 libgedit-amtk.spec: W: no-%check-section 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 23 filtered, 0 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: libgedit-amtk-debuginfo-5.9.0-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0sx614t8')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "libgedit-amtk". (none): E: there is no installed rpm "libgedit-amtk-debuginfo". ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "libgedit-amtk-devel". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://download.gnome.org/sources/libgedit-amtk/5.9/libgedit-amtk-5.9.0.tar.xz : CHECKSUM(SHA256) this package : 7fc3348bef242e08967bdbb9a6698cf39f7810f95051fd8132910f36ed2d6d15 CHECKSUM(SHA256) upstream package : 7fc3348bef242e08967bdbb9a6698cf39f7810f95051fd8132910f36ed2d6d15 Requires -------- libgedit-amtk (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) rtld(GNU_HASH) libgedit-amtk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libgedit-amtk(x86-64) libgedit-amtk-5.so.0()(64bit) pkgconfig(gio-2.0) pkgconfig(gtk+-3.0) Provides -------- libgedit-amtk: libgedit-amtk libgedit-amtk(x86-64) libgedit-amtk-5.so.0()(64bit) libgedit-amtk-devel: amtk-devel libgedit-amtk-devel libgedit-amtk-devel(x86-64) pkgconfig(amtk-5) pkgconfig(libgedit-amtk-5) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name libgedit-amtk --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, R, PHP, Python, SugarActivity, Perl, Ocaml, Haskell, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://yselkowitz.fedorapeople.org/libgedit-amtk.spec SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-amtk-5.9.0-1.fc43.src.rpm The only other amtk dependent actually drops the dependency with a minor version bump, which simplifies things here.
LGTM now. APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/libgedit-amtk
FEDORA-2025-677acc58ee (gedit-48.1-1.fc43, gedit-plugins-48.1-1.fc43, and 5 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-677acc58ee
FEDORA-2025-a0b416fb5a (gedit-48.1-1.fc42, gedit-plugins-48.1-1.fc42, and 5 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a0b416fb5a
FEDORA-2025-677acc58ee (gedit-48.1-1.fc43, gedit-plugins-48.1-1.fc43, and 5 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-a0b416fb5a has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a0b416fb5a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a0b416fb5a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-a0b416fb5a (gedit-48.1-1.fc42, gedit-plugins-48.1-1.fc42, and 5 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.