Bug 225894 - Merge Review: icon-naming-utils
Merge Review: icon-naming-utils
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:04 EST by Nobody's working on this, feel free to take it
Modified: 2009-01-13 23:59 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-01-13 23:59:28 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:04:31 EST
Fedora Merge Review: icon-naming-utils

Initial Owner: mclasen@redhat.com
Comment 1 Matthias Clasen 2007-11-18 01:13:07 EST
rpmlint says: 

[mclasen@localhost devel]$ rpmlint noarch/icon-naming-utils-0.8.6-1.fc9.noarch.rpm 
icon-naming-utils.noarch: W: devel-file-in-non-devel-package

Which is ignorable, since this is a development tool
Comment 2 Parag AN(पराग) 2008-12-24 01:08:08 EST
1) rpmlint output on SRPM and RPM
icon-naming-utils.src: I: checking
icon-naming-utils.src: W: no-%prep-section
icon-naming-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4)

icon-naming-utils.noarch: I: checking
icon-naming-utils.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/icon-naming-utils.pc
==> All Looks Ok

Though it looks bit odd to see icon-naming-utils.pc installed by this package.

2) License looks GPLv2 not GPL+
3) you can preserve timestamps using 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
Comment 3 Parag AN(पराग) 2008-12-29 23:13:16 EST
Comment 4 Michael Schwendt 2009-01-03 07:35:41 EST
> Requires:       perl(XML::Simple)

Redundant. rpmbuild adds it already.
Comment 5 Matthias Clasen 2009-01-03 12:56:04 EST
Feel free to remove it.
Comment 6 Parag AN(पराग) 2009-01-13 23:59:28 EST
APPROVED new rawhide build http://koji.fedoraproject.org/koji/buildinfo?buildID=78414

Note You need to log in before you can comment on or make changes to this bug.