Fedora Merge Review: icon-naming-utils http://cvs.fedora.redhat.com/viewcvs/devel/icon-naming-utils/ Initial Owner: mclasen
rpmlint says: [mclasen@localhost devel]$ rpmlint noarch/icon-naming-utils-0.8.6-1.fc9.noarch.rpm icon-naming-utils.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/icon-naming-utils.pc Which is ignorable, since this is a development tool
1) rpmlint output on SRPM and RPM icon-naming-utils.src: I: checking icon-naming-utils.src: W: no-%prep-section icon-naming-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4) icon-naming-utils.noarch: I: checking icon-naming-utils.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/icon-naming-utils.pc ==> All Looks Ok Though it looks bit odd to see icon-naming-utils.pc installed by this package. 2) License looks GPLv2 not GPL+ 3) you can preserve timestamps using make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
ping?
> Requires: perl(XML::Simple) Redundant. rpmbuild adds it already.
Feel free to remove it.
APPROVED new rawhide build http://koji.fedoraproject.org/koji/buildinfo?buildID=78414