Bug 2259011 - Review Request: libvpl - Intel Video Processing Library
Summary: Review Request: libvpl - Intel Video Processing Library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ali Erdinc Koroglu
QA Contact: Fedora Extras Quality Assurance
URL: https://intel.github.io/libvpl/latest...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-18 16:00 UTC by Simone Caronni
Modified: 2024-02-20 16:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-20 16:24:09 UTC
Type: ---
Embargoed:
aekoroglu: fedora-review+


Attachments (Terms of Use)

Description Simone Caronni 2024-01-18 16:00:10 UTC
Spec URL: https://slaanesh.fedorapeople.org/libvpl.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-2.10.1-1.fc39.src.rpm
Description:
The oneAPI Video Processing Library (oneVPL) provides a single video processing
API for encode, decode, and video processing that works across a wide range of
accelerators.

The base package is limited to the dispatcher and samples. To use oneVPL for
video processing you need to install at least one implementation. Current
implementations:

- oneVPL-intel-gpu for use on Intel Xe graphics and newer
- intel-mediasdk for use on legacy Intel graphics

Fedora Account System Username: slaanesh

Comment 1 Fedora Review Service 2024-01-18 16:00:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6915758
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259011-libvpl/srpm-builds/06915758/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Simone Caronni 2024-01-18 16:01:49 UTC
This review is for the renaming of the oneVPL package https://src.fedoraproject.org/rpms/oneVPL to libvpl, using also a new versioning scheme.

Comment 3 Ali Erdinc Koroglu 2024-02-09 14:47:30 UTC
Hello, Simone. Could you please fix these?

libvpl.x86_64: E: spelling-error ('oneAPI', '%description -l en_US oneAPI -> one API, one-API, Oneal')
libvpl.x86_64: E: spelling-error ('oneVPL', '%description -l en_US oneVPL -> Oneal')
libvpl.x86_64: E: spelling-error ('gpu', '%description -l en_US gpu -> GPU, pug, gnu')
libvpl.x86_64: E: spelling-error ('mediasdk', '%description -l en_US mediasdk -> mediated')

libvpl-devel.x86_64: E: pkgconfig-exception /usr/lib64/pkgconfig/vpl.pc 'utf-8' codec can't decode byte 0xae in position 101: invalid start byte

Comment 4 Simone Caronni 2024-02-13 15:12:27 UTC
(In reply to Ali Erdinc Koroglu from comment #3)
> Hello, Simone. Could you please fix these?
> 
> libvpl.x86_64: E: spelling-error ('oneAPI', '%description -l en_US oneAPI ->
> one API, one-API, Oneal')
> libvpl.x86_64: E: spelling-error ('oneVPL', '%description -l en_US oneVPL ->
> Oneal')
> libvpl.x86_64: E: spelling-error ('gpu', '%description -l en_US gpu -> GPU,
> pug, gnu')
> libvpl.x86_64: E: spelling-error ('mediasdk', '%description -l en_US
> mediasdk -> mediated')

Ehm.... no? They are all correct, check the spec file.

> libvpl-devel.x86_64: E: pkgconfig-exception /usr/lib64/pkgconfig/vpl.pc
> 'utf-8' codec can't decode byte 0xae in position 101: invalid start byte

Fixed, I had to switch from Intel® to Intel in the pkgconfig file.

Spec URL: https://slaanesh.fedorapeople.org/libvpl.spec
SRPM URL: https://slaanesh.fedorapeople.org/libvpl-2.10.1-2.fc39.src.rpm

Comment 5 Fedora Review Service 2024-02-13 15:18:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7012036
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259011-libvpl/fedora-rawhide-x86_64/07012036-libvpl/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Ali Erdinc Koroglu 2024-02-14 15:57:53 UTC
Hello Simone,
Looks good to me. Approved

Comment 7 Simone Caronni 2024-02-16 14:46:34 UTC
Thanks!

Comment 8 Simone Caronni 2024-02-16 14:53:00 UTC
@ali.erdinc.koroglu you need to set fedora-review "+", not remove the flag. Otherwise I can not request the branches.

Thanks.

Comment 9 Simone Caronni 2024-02-16 14:53:00 UTC
@ali.erdinc.koroglu you need to set fedora-review "+", not remove the flag. Otherwise I can not request the branches.

Thanks.

Comment 10 Ali Erdinc Koroglu 2024-02-19 06:05:44 UTC
Sure

Comment 11 Fedora Admin user for bugzilla script actions 2024-02-20 13:10:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libvpl


Note You need to log in before you can comment on or make changes to this bug.