Bug 2259040 - Review Request: rust-scx_rusty - Userspace scheduling with BPF
Summary: Review Request: rust-scx_rusty - Userspace scheduling with BPF
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/scx_rusty
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-18 19:30 UTC by Jordan Rome
Modified: 2024-01-25 23:00 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-25 23:00:21 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Jordan Rome 2024-01-18 19:30:16 UTC
Spec URL: https://jordalgo.fedorapeople.org/review/rust-scx_rusty/rust-scx_rusty.spec
SRPM URL: https://jordalgo.fedorapeople.org/review/rust-scx_rusty/rust-scx_rusty-0.5.3-1.fc40.src.rpm

Description:
Userspace scheduling with BPF.

Fedora Account System Username: jordalgo

Comment 1 Jordan Rome 2024-01-18 19:30:19 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=111935270

Comment 2 Fedora Review Service 2024-01-18 19:31:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916106
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259040-rust-scx_rusty/srpm-builds/06916106/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jordan Rome 2024-01-19 02:43:52 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-01-19 02:58:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916578
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259040-rust-scx_rusty/fedora-rawhide-x86_64/06916578-rust-scx_rusty/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Jordan Rome 2024-01-19 19:07:28 UTC
Updated the summary and description. The urls are the same for the spec file and the rpm.
Here is the additional file: https://jordalgo.fedorapeople.org/review/rust-scx_rusty/rust2rpm.toml

Comment 6 Michel Lind 2024-01-19 19:33:04 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (GPL-2.0-only) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-01-20 20:03:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-scx_rusty

Comment 8 Fabio Valentini 2024-01-25 23:00:21 UTC
This has been imported. Please don't forget to close review tickets after importing the package.


Note You need to log in before you can comment on or make changes to this bug.