This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=111949788

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916607
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259075-rust-scx_rustland/srpm-builds/06916607/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6916609
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259075-rust-scx_rustland/fedora-rawhide-x86_64/06916609-rust-scx_rustland/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I see three minor issues:

1. You added "ExcludeArch: %{ix86}", is there a reason for that? Or do you just not want to bother building for an architecture that is on life-support? If that *is* the reason, that is fine, since this is a binary-only Rust crate and no other Rust packages can depend on it - I just want to make sure.

2. Please include the full output of the %cargo_license_summary macro as a comment in the spec file, as suggested by the generated FIXME comment. The list is much more informative than the ANDed license tag below.

3. The license tag for the binary subpackage is more complicated than it needs to be. The AND and OR operators in SPDX are commutative and associative, so you can do the following:

- Drop parentheses around "((MIT OR Apache-2.0) AND Unicode-DFS-2016)" since "(A AND B) AND C" is the same as "A AND B AND C".
- Drop "(MIT OR Apache-2.0)", you already have "(Apache-2.0 OR MIT)".
- Reorder to be in alphabetical order so there's a consistent order (I usually do items without parenthesized OR clauses in alphabetical order first, then the parenthesized items in alphabetical order).

That should make the License tag a bit more readable and a bit shorter as well.

Updated the spec file and rpm with a new summary and description.

https://jordalgo.fedorapeople.org/review/rust-scx_rustland/rust2rpm.toml

> Or do you just not want to bother building for an architecture that is on life-support? If that *is* the reason, that is fine, since this is a binary-only Rust crate and no other Rust packages can depend on it - I just want to make sure.

Yeah that's pretty much the reason. This package doesn't currently build on this architecture and I'm not sure it's worth trying to get it to work there.

Thanks, package looks good to me. Please submit the updated summary / description to upstream.
Note that these are the same metadata field in Cargo.toml, so something where the first chunk works as a summary and the whole thing can be taken as a description would be best.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please take care when updating this package or any Rust libraries, as there are some things that are specific to Rust packaging that are sometimes tricky for newcomers:

- the license summary / tag should be updated for every new version to ensure it's kept accurate
- updates for semver incompatible versions need to be coordinated with dependent packages (i.e. v0.2 to v0.3, or v1 to v2)

@decathorpe Thanks for the reviews!

(removing accidental NEEDINFO flags)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-scx_rustland

This has been imported. Please don't forget to close review tickets after importing the package.

My bad. Thanks for closing this and the other scx packages.