Bug 225911 - Merge Review: ipvsadm
Merge Review: ipvsadm
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:07 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-18 09:29 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-18 09:29:24 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:07:04 EST
Fedora Merge Review: ipvsadm

http://cvs.fedora.redhat.com/viewcvs/devel/ipvsadm/
Initial Owner: kupcevic@redhat.com
Comment 1 Parag AN(पराग) 2007-08-31 01:25:22 EDT
Correct Buildroot.
Use macros. check http://fedoraproject.org/wiki/Packaging/RPMMacros
Though dist tag is not mandatory but its good to have it in SPEC.
update SPEC for further review.
Comment 2 Matthias Saou 2007-11-27 08:09:21 EST
Update what? I won't add any dist tag, because the package pretty much never
changes. Could you detail "Use macros.", please?
Comment 3 Parag AN(पराग) 2007-11-27 09:03:46 EST
(In reply to comment #2)
> Update what? I won't add any dist tag, because the package pretty much never
> changes. Could you detail "Use macros.", please?
Fine.
I think I have given link where to look for using macros in SPEC.
Review Guidelines said
- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. 

And I only asked you to change
/etc/rc.d/init.d under %flies as given
http://fedoraproject.org/wiki/Packaging/RPMMacros on as
/etc/rc.d/init.d => %{_initrddir}
Comment 4 Matthias Saou 2007-11-27 11:25:29 EST
No, I won't use that macro. It's wrong, plain wrong. If it was called _initddir
or even _initdir, why not.
Comment 5 Parag AN(पराग) 2007-11-27 11:56:39 EST
Then should we ask Fedora Packaging Committee to remove that usage if its wrong
way to use that macro?
Comment 6 Parag AN(पराग) 2008-01-18 09:29:24 EST
otherwise else spec looks fine.

APPROVED.

Note You need to log in before you can comment on or make changes to this bug.